Add new fields to vpn-community-star (#110)

* Add new nat module

* Support nat-rule relative positioning + bug fix

* New Resource Modules

* split vpn param that can accept either a String or list of objects to two

* Add new fields to vpn-community-star

Author: chkp-edenbr

CHANGELOG.rst

@@ -5,6 +5,25 @@ Check_Point.Mgmt Release Notes
 .. contents:: Topics
 
 
+v5.1.0
+======
+
+Release Summary
+---------------
+
+This is release 5.1.0 of ``check_point.mgmt``, released on 2023-05-18.
+
+Minor Changes
+-------------
+
+- cp_mgmt_vpn_community_star - new fields added.
+- show command modules  - no longer return result of changed=True.
+
+Bugfixes
+--------
+
+- cp_mgmt_access_rules - split vpn param that can accept either a String or list of objects to two
+
 v5.0.0
 ======
 

changelogs/.plugin-cache.yaml

@@ -1457,4 +1457,4 @@ plugins:
   shell: {}
   strategy: {}
   vars: {}
-version: 5.0.0
+version: 5.1.0

changelogs/changelog.yaml

@@ -1012,3 +1012,16 @@ releases:
       name: cp_mgmt_where_used
       namespace: ''
     release_date: '2022-07-10'
+  5.1.0:
+    changes:
+      bugfixes:
+      - cp_mgmt_access_rules - split vpn param that can accept either a String or
+        list of objects to two
+      minor_changes:
+      - cp_mgmt_vpn_community_star - new fields added.
+      - show command modules  - no longer return result of changed=True.
+      release_summary: This is release 5.1.0 of ``check_point.mgmt``, released on
+        2023-05-18.
+    fragments:
+    - 5.1.0.yml
+    release_date: '2022-07-16'

galaxy.yml

@@ -9,7 +9,7 @@ namespace: check_point
 name: mgmt
 
 # The version of the collection. Must be compatible with semantic versioning
-version: 5.0.0
+version: 5.1.0
 
 # The path to the Markdown (.md) readme file. This path is relative to the root of the collection
 readme: README.md

plugins/module_utils/checkpoint.py

@@ -31,7 +31,6 @@
 __metaclass__ = type
 
 import time
-from ansible.errors import AnsibleActionFail
 from ansible.module_utils.six import iteritems
 from ansible.module_utils.urls import CertificateError
 from ansible.module_utils.connection import ConnectionError
@@ -94,11 +93,11 @@
 
 
 def _fail_json(msg):
-    """Replace the AnsibleModule fai;_json here
+    """Replace the AnsibleModule fail_json here
     :param msg: The message for the failure
     :type msg: str
     """
-    raise AnsibleActionFail(msg)
+    raise Exception(msg)
 
 
 def map_params_to_obj(module_params, key_transform):
@@ -532,7 +531,7 @@ def api_command(module, command):
 
     code, response = send_request(connection, version, command, payload)
     result = {"changed": True}
-    
+
     if command.startswith("show"):
         result['changed'] = False
 
@@ -679,15 +678,15 @@ def api_call(module, api_call_object):
     return result
 
 
-# returns a generator of the entire rulebase
+# returns a generator of the entire rulebase. show_rulebase_identifier_payload can be either package or layer
 def get_rulebase_generator(
     connection, version, show_rulebase_identifier_payload, show_rulebase_command, rules_amount
 ):
     offset = 0
     limit = 100
     while True:
         payload_for_show_rulebase = {
-            **show_rulebase_identifier_payload,  # package or layer
+            **show_rulebase_identifier_payload,
             "limit": limit,
             "offset": offset,
         }

plugins/modules/cp_mgmt_add_api_key.py

@@ -53,7 +53,6 @@
 - name: add-api-key
   cp_mgmt_add_api_key:
     admin_name: admin
-    state: present
 """
 
 RETURN = """

plugins/modules/cp_mgmt_add_data_center_object.py

@@ -101,7 +101,6 @@
   cp_mgmt_add_data_center_object:
     data_center_name: vCenter 1
     name: VM1 mgmt name
-    state: present
     uri: /Datacenters/VMs/My VM1
 """
 

plugins/modules/cp_mgmt_add_nat_rule.py

@@ -119,7 +119,6 @@
     original_source: Any
     package: standard
     position: 1
-    state: present
 """
 
 RETURN = """

plugins/modules/cp_mgmt_add_repository_package.py

@@ -58,7 +58,6 @@
     name: Check_Point_R80_20_JUMBO_HF_Bundle_T118_sk137592_Security_Gateway_and_Standalone_2_6_18_FULL.tgz
     path: /home/admin/
     source: local
-    state: present
 """
 
 RETURN = """

plugins/modules/cp_mgmt_add_updatable_object.py

@@ -74,7 +74,6 @@
 EXAMPLES = """
 - name: add-updatable-object
   cp_mgmt_add_updatable_object:
-    state: present
     uri: '{{uri}}'
 """