Updated modules batch 3

Author: chkp-edenbr

plugins/modules/cp_mgmt_multicast_address_range.py

@@ -32,7 +32,7 @@
 description:
   - Manages multicast-address-range objects on Check Point devices including creating, updating and removing objects.
   - All operations are performed over Web Services API.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   name:
@@ -80,6 +80,7 @@
     description:
       - Collection of tag identifiers.
     type: list
+    elements: str
   color:
     description:
       - Color of the object. Should be one of existing colors.
@@ -101,6 +102,7 @@
     description:
       - Collection of group identifiers.
     type: list
+    elements: str
   ignore_warnings:
     description:
       - Apply changes ignoring warnings.
@@ -156,15 +158,15 @@ def main():
         ip_address_last=dict(type='str'),
         ipv4_address_last=dict(type='str'),
         ipv6_address_last=dict(type='str'),
-        tags=dict(type='list'),
+        tags=dict(type='list', elements='str'),
         color=dict(type='str', choices=['aquamarine', 'black', 'blue', 'crete blue', 'burlywood', 'cyan', 'dark green',
                                         'khaki', 'orchid', 'dark orange', 'dark sea green', 'pink', 'turquoise', 'dark blue', 'firebrick', 'brown',
                                         'forest green', 'gold', 'dark gold', 'gray', 'dark gray', 'light green', 'lemon chiffon', 'coral', 'sea green',
                                         'sky blue', 'magenta', 'purple', 'slate blue', 'violet red', 'navy blue', 'olive', 'orange', 'red', 'sienna',
                                         'yellow']),
         comments=dict(type='str'),
         details_level=dict(type='str', choices=['uid', 'standard', 'full']),
-        groups=dict(type='list'),
+        groups=dict(type='list', elements='str'),
         ignore_warnings=dict(type='bool'),
         ignore_errors=dict(type='bool')
     )

plugins/modules/cp_mgmt_multicast_address_range_facts.py

@@ -34,7 +34,7 @@
   - All operations are performed over Web Services API.
   - This module handles both operations, get a specific object and get several objects,
     For getting a specific object use the parameter 'name'.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   name:
@@ -63,6 +63,7 @@
       - Sorts results by the given field. By default the results are sorted in the ascending order by name.
         This parameter is relevant only for getting few objects.
     type: list
+    elements: dict
     suboptions:
       ASC:
         description:
@@ -108,15 +109,15 @@ def main():
         details_level=dict(type='str', choices=['uid', 'standard', 'full']),
         limit=dict(type='int'),
         offset=dict(type='int'),
-        order=dict(type='list', options=dict(
+        order=dict(type='list', elements='dict', options=dict(
             ASC=dict(type='str', choices=['name']),
             DESC=dict(type='str', choices=['name'])
         )),
         show_membership=dict(type='bool')
     )
     argument_spec.update(checkpoint_argument_spec_for_facts)
 
-    module = AnsibleModule(argument_spec=argument_spec)
+    module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=True)
 
     api_call_object = "multicast-address-range"
     api_call_object_plural_version = "multicast-address-ranges"

plugins/modules/cp_mgmt_nat_rule_facts.py

@@ -34,7 +34,7 @@
   - All operations are performed over Web Services API.
   - This module handles both operations, get a specific object and get several objects,
     For getting a specific object use the parameter 'name'.
-version_added: "2.9"
+version_added: "2.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   rule_number:
@@ -110,6 +110,7 @@
       - Sorts the results by search criteria. Automatically sorts the results by Name, in the ascending order.
         This parameter is relevant only for getting few objects.
     type: list
+    elements: dict
     suboptions:
       ASC:
         description:
@@ -179,7 +180,7 @@ def main():
         )),
         limit=dict(type='int'),
         offset=dict(type='int'),
-        order=dict(type='list', options=dict(
+        order=dict(type='list', elements='dict', options=dict(
             ASC=dict(type='str', choices=['name']),
             DESC=dict(type='str', choices=['name'])
         )),
@@ -189,7 +190,7 @@ def main():
     )
     argument_spec.update(checkpoint_argument_spec_for_facts)
 
-    module = AnsibleModule(argument_spec=argument_spec)
+    module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=True)
 
     api_call_object = "nat-rule"
     api_call_object_plural_version = "nat-rulebase"

plugins/modules/cp_mgmt_nat_section.py

@@ -32,7 +32,7 @@
 description:
   - Manages nat-section objects on Checkpoint devices including creating, updating and removing objects.
   - All operations are performed over Web Services API.
-version_added: "2.9"
+version_added: "2.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   package:

plugins/modules/cp_mgmt_network.py

@@ -32,7 +32,7 @@
 description:
   - Manages network objects on Check Point devices including creating, updating and removing objects.
   - All operations are performed over Web Services API.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   name:
@@ -109,6 +109,7 @@
     description:
       - Collection of tag identifiers.
     type: list
+    elements: str
   broadcast:
     description:
       - Allow broadcast address inclusion.
@@ -135,6 +136,7 @@
     description:
       - Collection of group identifiers.
     type: list
+    elements: str
   ignore_warnings:
     description:
       - Apply changes ignoring warnings.
@@ -199,7 +201,7 @@ def main():
             install_on=dict(type='str'),
             method=dict(type='str', choices=['hide', 'static'])
         )),
-        tags=dict(type='list'),
+        tags=dict(type='list', elements='str'),
         broadcast=dict(type='str', choices=['disallow', 'allow']),
         color=dict(type='str', choices=['aquamarine', 'black', 'blue', 'crete blue', 'burlywood', 'cyan', 'dark green',
                                         'khaki', 'orchid', 'dark orange', 'dark sea green', 'pink', 'turquoise', 'dark blue', 'firebrick', 'brown',
@@ -208,7 +210,7 @@ def main():
                                         'yellow']),
         comments=dict(type='str'),
         details_level=dict(type='str', choices=['uid', 'standard', 'full']),
-        groups=dict(type='list'),
+        groups=dict(type='list', elements='str'),
         ignore_warnings=dict(type='bool'),
         ignore_errors=dict(type='bool')
     )

plugins/modules/cp_mgmt_network_facts.py

@@ -34,7 +34,7 @@
   - All operations are performed over Web Services API.
   - This module handles both operations, get a specific object and get several objects,
     For getting a specific object use the parameter 'name'.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   name:
@@ -63,6 +63,7 @@
       - Sorts results by the given field. By default the results are sorted in the ascending order by name.
         This parameter is relevant only for getting few objects.
     type: list
+    elements: dict
     suboptions:
       ASC:
         description:
@@ -110,15 +111,15 @@ def main():
         details_level=dict(type='str', choices=['uid', 'standard', 'full']),
         limit=dict(type='int'),
         offset=dict(type='int'),
-        order=dict(type='list', options=dict(
+        order=dict(type='list', elements='dict', options=dict(
             ASC=dict(type='str', choices=['name']),
             DESC=dict(type='str', choices=['name'])
         )),
         show_membership=dict(type='bool')
     )
     argument_spec.update(checkpoint_argument_spec_for_facts)
 
-    module = AnsibleModule(argument_spec=argument_spec)
+    module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=True)
 
     api_call_object = "network"
     api_call_object_plural_version = "networks"

plugins/modules/cp_mgmt_package.py

@@ -32,7 +32,7 @@
 description:
   - Manages package objects on Check Point devices including creating, updating and removing objects.
   - All operations are performed over Web Services API.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   name:
@@ -52,6 +52,7 @@
     description:
       - Which Gateways identified by the name or UID to install the policy on.
     type: list
+    elements: str
   qos:
     description:
       - True - enables, False - disables QoS policy, empty - nothing is changed.
@@ -65,6 +66,7 @@
     description:
       - Collection of tag identifiers.
     type: list
+    elements: str
   threat_prevention:
     description:
       - True - enables, False - disables Threat policy, empty - nothing is changed.
@@ -107,6 +109,7 @@
         description:
           - Collection of Access layer objects to be added identified by the name or UID.
         type: list
+        elements: dict
         suboptions:
           name:
             description:
@@ -120,10 +123,12 @@
         description:
           - Collection of Access layer objects to be removed identified by the name or UID.
         type: list
+        elements: str
       value:
         description:
           - Collection of Access layer objects to be set identified by the name or UID. Replaces existing Access layers.
         type: list
+        elements: str
   threat_layers:
     description:
       - Threat policy layers.
@@ -133,6 +138,7 @@
         description:
           - Collection of Threat layer objects to be added identified by the name or UID.
         type: list
+        elements: dict
         suboptions:
           name:
             description:
@@ -146,10 +152,12 @@
         description:
           - Collection of Threat layer objects to be removed identified by the name or UID.
         type: list
+        elements: str
       value:
         description:
           - Collection of Threat layer objects to be set identified by the name or UID. Replaces existing Threat layers.
         type: list
+        elements: str
 extends_documentation_fragment: check_point.mgmt.checkpoint_objects
 """
 
@@ -198,10 +206,10 @@ def main():
         name=dict(type='str', required=True),
         access=dict(type='bool'),
         desktop_security=dict(type='bool'),
-        installation_targets=dict(type='list'),
+        installation_targets=dict(type='list', elements='str'),
         qos=dict(type='bool'),
         qos_policy_type=dict(type='str', choices=['recommended', 'express']),
-        tags=dict(type='list'),
+        tags=dict(type='list', elements='str'),
         threat_prevention=dict(type='bool'),
         vpn_traditional_mode=dict(type='bool'),
         color=dict(type='str', choices=['aquamarine', 'black', 'blue', 'crete blue', 'burlywood', 'cyan', 'dark green',
@@ -214,20 +222,20 @@ def main():
         ignore_warnings=dict(type='bool'),
         ignore_errors=dict(type='bool'),
         access_layers=dict(type='dict', options=dict(
-            add=dict(type='list', options=dict(
+            add=dict(type='list', elements='dict', options=dict(
                 name=dict(type='str'),
                 position=dict(type='int')
             )),
-            remove=dict(type='list'),
-            value=dict(type='list')
+            remove=dict(type='list', elements='str'),
+            value=dict(type='list', elements='str')
         )),
         threat_layers=dict(type='dict', options=dict(
-            add=dict(type='list', options=dict(
+            add=dict(type='list', elements='dict', options=dict(
                 name=dict(type='str'),
                 position=dict(type='int')
             )),
-            remove=dict(type='list'),
-            value=dict(type='list')
+            remove=dict(type='list', elements='str'),
+            value=dict(type='list', elements='str')
         ))
     )
     argument_spec.update(checkpoint_argument_spec_for_objects)

plugins/modules/cp_mgmt_package_facts.py

@@ -34,7 +34,7 @@
   - All operations are performed over Web Services API.
   - This module handles both operations, get a specific object and get several objects,
     For getting a specific object use the parameter 'name'.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   name:
@@ -63,6 +63,7 @@
       - Sorts results by the given field. By default the results are sorted in the ascending order by name.
         This parameter is relevant only for getting few objects.
     type: list
+    elements: dict
     suboptions:
       ASC:
         description:
@@ -106,14 +107,14 @@ def main():
         details_level=dict(type='str', choices=['uid', 'standard', 'full']),
         limit=dict(type='int'),
         offset=dict(type='int'),
-        order=dict(type='list', options=dict(
+        order=dict(type='list', elements='dict', options=dict(
             ASC=dict(type='str', choices=['name']),
             DESC=dict(type='str', choices=['name'])
         ))
     )
     argument_spec.update(checkpoint_argument_spec_for_facts)
 
-    module = AnsibleModule(argument_spec=argument_spec)
+    module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=True)
 
     api_call_object = "package"
     api_call_object_plural_version = "packages"

plugins/modules/cp_mgmt_publish.py

@@ -32,7 +32,7 @@
 description:
   - All the changes done by this user will be seen by all users only after publish is called.
   - All operations are performed over Web Services API.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   uid:

plugins/modules/cp_mgmt_put_file.py

@@ -32,13 +32,14 @@
 description:
   - put file on Check Point over Web Services API
   - All operations are performed over Web Services API.
-version_added: "2.9"
+version_added: "1.0.0"
 author: "Or Soffer (@chkp-orso)"
 options:
   targets:
     description:
       - On what targets to execute this command. Targets may be identified by their name, or object unique identifier.
     type: list
+    elements: str
   file_content:
     description:
       - N/A
@@ -81,7 +82,7 @@
 
 def main():
     argument_spec = dict(
-        targets=dict(type='list'),
+        targets=dict(type='list', elements='str'),
         file_content=dict(type='str'),
         file_name=dict(type='str'),
         file_path=dict(type='str'),