To fix pep8 Ansible guidelines (#92)

* fix pep8 ansible guidelines n enable Ansible gh actions

* remove ansible GH actions

Author: justjais

plugins/action/cp_mgmt_access_rules.py

@@ -1,60 +1,91 @@
-from __future__ import (absolute_import, division, print_function)
+from __future__ import absolute_import, division, print_function
 
 __metaclass__ = type
 
 
 from ansible.errors import AnsibleActionFail
 from ansible.plugins.action import ActionBase
-from ansible_collections.check_point.mgmt.plugins.module_utils.checkpoint import \
-    prepare_rule_params_for_execute_module, check_if_to_publish_for_action
+from ansible_collections.check_point.mgmt.plugins.module_utils.checkpoint import (
+    prepare_rule_params_for_execute_module,
+    check_if_to_publish_for_action,
+)
 
 
 class ActionModule(ActionBase):
-
     def run(self, tmp=None, task_vars=None):
 
         module = super(ActionModule, self).run(tmp, task_vars)
 
-        result = self._execute_module(module_name='check_point.mgmt.cp_mgmt_access_rules', module_args=self._task.args,
-                                      task_vars=task_vars, tmp=tmp)
+        result = self._execute_module(
+            module_name="check_point.mgmt.cp_mgmt_access_rules",
+            module_args=self._task.args,
+            task_vars=task_vars,
+            tmp=tmp,
+        )
 
-        if 'msg' in result.keys():
-            raise AnsibleActionFail(result['msg'])
+        if "msg" in result.keys():
+            raise AnsibleActionFail(result["msg"])
 
         module_args = self._task.args
 
-        fields = {'position', 'layer', 'auto_publish_session'}
-        rules_list = module_args['rules']
+        fields = {"position", "layer", "auto_publish_session"}
+        rules_list = module_args["rules"]
         for rule in rules_list:
             for field in fields:
                 if field in rule.keys():
-                    raise AnsibleActionFail('Unsupported parameter ' + field + ' for rule')
+                    raise AnsibleActionFail(
+                        "Unsupported parameter " + field + " for rule"
+                    )
         # check_fields_for_rule_action_module(module_args)
-        rules_list = self._task.args['rules']
+        rules_list = self._task.args["rules"]
         position = 1
         below_rule_name = None
 
         for rule in rules_list:
-            rule, position, below_rule_name = prepare_rule_params_for_execute_module(rule=rule, module_args=module_args,
-                                                                                     position=position,
-                                                                                     below_rule_name=below_rule_name)
-
-            result['rule: ' + rule['name']] = self._execute_module(module_name='check_point.mgmt.cp_mgmt_access_rule',
-                                                                   module_args=rule,
-                                                                   task_vars=task_vars, tmp=tmp, wrap_async=False)
-            if 'changed' in result['rule: ' + rule['name']].keys() and \
-                    result['rule: ' + rule['name']]['changed'] is True:
-                result['changed'] = True
-            if 'failed' in result['rule: ' + rule['name']].keys() and result['rule: ' + rule['name']]['failed'] is True:
-                temp = result['rule: ' + rule['name']].copy()
+            (
+                rule,
+                position,
+                below_rule_name,
+            ) = prepare_rule_params_for_execute_module(
+                rule=rule,
+                module_args=module_args,
+                position=position,
+                below_rule_name=below_rule_name,
+            )
+
+            result["rule: " + rule["name"]] = self._execute_module(
+                module_name="check_point.mgmt.cp_mgmt_access_rule",
+                module_args=rule,
+                task_vars=task_vars,
+                tmp=tmp,
+                wrap_async=False,
+            )
+            if (
+                "changed" in result["rule: " + rule["name"]].keys()
+                and result["rule: " + rule["name"]]["changed"] is True
+            ):
+                result["changed"] = True
+            if (
+                "failed" in result["rule: " + rule["name"]].keys()
+                and result["rule: " + rule["name"]]["failed"] is True
+            ):
+                temp = result["rule: " + rule["name"]].copy()
                 result = {}
-                result['rule: ' + rule['name']] = temp
-                result['failed'] = True
-                result['discard:'] = self._execute_module(module_name='check_point.mgmt.cp_mgmt_discard',
-                                                          module_args={}, task_vars=task_vars, tmp=tmp)
+                result["rule: " + rule["name"]] = temp
+                result["failed"] = True
+                result["discard:"] = self._execute_module(
+                    module_name="check_point.mgmt.cp_mgmt_discard",
+                    module_args={},
+                    task_vars=task_vars,
+                    tmp=tmp,
+                )
                 break
         if check_if_to_publish_for_action(result, module_args):
-            result['publish:'] = self._execute_module(module_name='check_point.mgmt.cp_mgmt_publish', module_args={},
-                                                      task_vars=task_vars, tmp=tmp)
+            result["publish:"] = self._execute_module(
+                module_name="check_point.mgmt.cp_mgmt_publish",
+                module_args={},
+                task_vars=task_vars,
+                tmp=tmp,
+            )
 
         return result

plugins/doc_fragments/checkpoint_commands.py

@@ -3,14 +3,15 @@
 # Copyright: (c) 2019, Or Soffer <orso@checkpoint.com>
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
-from __future__ import (absolute_import, division, print_function)
+from __future__ import absolute_import, division, print_function
+
 __metaclass__ = type
 
 
 class ModuleDocFragment(object):
 
     # Standard files documentation fragment
-    DOCUMENTATION = r'''
+    DOCUMENTATION = r"""
 options:
   wait_for_task:
     description:
@@ -26,4 +27,4 @@ class ModuleDocFragment(object):
     description:
       - Version of checkpoint. If not given one, the latest version taken.
     type: str
-'''
+"""

plugins/doc_fragments/checkpoint_facts.py

@@ -3,17 +3,18 @@
 # Copyright: (c) 2019, Or Soffer <orso@checkpoint.com>
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
-from __future__ import (absolute_import, division, print_function)
+from __future__ import absolute_import, division, print_function
+
 __metaclass__ = type
 
 
 class ModuleDocFragment(object):
 
     # Standard files documentation fragment
-    DOCUMENTATION = r'''
+    DOCUMENTATION = r"""
 options:
   version:
     description:
       - Version of checkpoint. If not given one, the latest version taken.
     type: str
-'''
+"""

plugins/doc_fragments/checkpoint_objects.py

@@ -3,14 +3,15 @@
 # Copyright: (c) 2019, Or Soffer <orso@checkpoint.com>
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
-from __future__ import (absolute_import, division, print_function)
+from __future__ import absolute_import, division, print_function
+
 __metaclass__ = type
 
 
 class ModuleDocFragment(object):
 
     # Standard files documentation fragment
-    DOCUMENTATION = r'''
+    DOCUMENTATION = r"""
 options:
   state:
     description:
@@ -39,4 +40,4 @@ class ModuleDocFragment(object):
     description:
       - Version of checkpoint. If not given one, the latest version taken.
     type: str
-'''
+"""

plugins/doc_fragments/checkpoint_objects_action_module.py

@@ -3,14 +3,15 @@
 # Copyright: (c) 2019, Or Soffer <orso@checkpoint.com>
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
-from __future__ import (absolute_import, division, print_function)
+from __future__ import absolute_import, division, print_function
+
 __metaclass__ = type
 
 
 class ModuleDocFragment(object):
 
     # Standard files documentation fragment
-    DOCUMENTATION = r'''
+    DOCUMENTATION = r"""
 options:
   auto_publish_session:
     description:
@@ -26,4 +27,4 @@ class ModuleDocFragment(object):
     description:
       - Version of checkpoint. If not given one, the latest version taken.
     type: str
-'''
+"""

plugins/httpapi/checkpoint.py

@@ -1,7 +1,7 @@
 # (c) 2018 Red Hat Inc.
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 
-from __future__ import (absolute_import, division, print_function)
+from __future__ import absolute_import, division, print_function
 
 __metaclass__ = type
 
@@ -44,53 +44,59 @@
 from ansible.module_utils.connection import ConnectionError
 
 BASE_HEADERS = {
-    'Content-Type': 'application/json',
-    'User-Agent': 'Ansible',
+    "Content-Type": "application/json",
+    "User-Agent": "Ansible",
 }
 
 
 class HttpApi(HttpApiBase):
     def login(self, username, password):
         payload = {}
-        cp_domain = self.get_option('domain')
-        cp_api_key = self.get_option('api_key')
+        cp_domain = self.get_option("domain")
+        cp_api_key = self.get_option("api_key")
         if cp_domain:
-            payload['domain'] = cp_domain
+            payload["domain"] = cp_domain
         if username and password and not cp_api_key:
-            payload['user'] = username
-            payload['password'] = password
+            payload["user"] = username
+            payload["password"] = password
         elif cp_api_key and not username and not password:
-            payload['api-key'] = cp_api_key
+            payload["api-key"] = cp_api_key
         else:
-            raise AnsibleConnectionFailure('[Username and password] or api_key are required for login')
-        url = '/web_api/login'
+            raise AnsibleConnectionFailure(
+                "[Username and password] or api_key are required for login"
+            )
+        url = "/web_api/login"
         response, response_data = self.send_request(url, payload)
 
         try:
-            self.connection._auth = {'X-chkp-sid': response_data['sid']}
+            self.connection._auth = {"X-chkp-sid": response_data["sid"]}
         except KeyError:
             raise ConnectionError(
-                'Server returned response without token info during connection authentication: %s' % response)
+                "Server returned response without token info during connection authentication: %s"
+                % response
+            )
         # Case of read-only
-        if 'uid' in response_data.keys():
-            self.connection._session_uid = response_data['uid']
+        if "uid" in response_data.keys():
+            self.connection._session_uid = response_data["uid"]
 
     def logout(self):
-        url = '/web_api/logout'
+        url = "/web_api/logout"
 
         response, dummy = self.send_request(url, None)
 
     def get_session_uid(self):
         return self.connection._session_uid
 
     def send_request(self, path, body_params):
-        data = json.dumps(body_params) if body_params else '{}'
-        cp_cloud_mgmt_id = self.get_option('cloud_mgmt_id')
+        data = json.dumps(body_params) if body_params else "{}"
+        cp_cloud_mgmt_id = self.get_option("cloud_mgmt_id")
         if cp_cloud_mgmt_id:
-            path = '/' + cp_cloud_mgmt_id + path
+            path = "/" + cp_cloud_mgmt_id + path
         try:
             self._display_request()
-            response, response_data = self.connection.send(path, data, method='POST', headers=BASE_HEADERS)
+            response, response_data = self.connection.send(
+                path, data, method="POST", headers=BASE_HEADERS
+            )
             value = self._get_response_value(response_data)
 
             return response.getcode(), self._response_to_json(value)
@@ -101,7 +107,9 @@ def send_request(self, path, body_params):
             return e.code, error
 
     def _display_request(self):
-        self.connection.queue_message('vvvv', 'Web Services: %s %s' % ('POST', self.connection._url))
+        self.connection.queue_message(
+            "vvvv", "Web Services: %s %s" % ("POST", self.connection._url)
+        )
 
     def _get_response_value(self, response_data):
         return to_text(response_data.getvalue())
@@ -111,4 +119,4 @@ def _response_to_json(self, response_text):
             return json.loads(response_text) if response_text else {}
         # JSONDecodeError only available on Python 3.5+
         except ValueError:
-            raise ConnectionError('Invalid JSON response: %s' % response_text)
+            raise ConnectionError("Invalid JSON response: %s" % response_text)