Merge pull request #176 from chkp-dorbe/master

fix v6.4.1

Author: chkp-dorbe

CHANGELOG.rst

@@ -10,7 +10,7 @@ v6.4.1
 Release Summary
 ---------------
 
-This is release 6.4.1 of "check_point.mgmt", released on 2025-05-28.
+This is release 6.4.1 of "check_point.mgmt", released on 2025-06-03.
 
 Bugfixes
 --------

changelogs/changelog.yaml

@@ -1304,10 +1304,10 @@ releases:
       bugfixes:
         - Added required management version to the documentation for all collection
           modules.
-        - "module_utils/checkpoint \u2013 Prevent redundant logout call when there is
-          no authentication header 'X-chkp-sid'."
-      release_summary: This is release 6.4.1 of ``check_point.mgmt``, released on
-        2025-05-28.
+        - module_utils/checkpoint - Prevent redundant logout call when there is
+          no authentication header 'X-chkp-sid'.
+      release_summary: This is release 6.4.1 of "check_point.mgmt", released on
+        2025-06-01.
     fragments:
       - 6.4.1.yml
-    release_date: '2025-05-28'
+    release_date: '2025-06-03'

plugins/module_utils/checkpoint.py

@@ -1014,7 +1014,7 @@ def get_number_and_section_from_position(
     show_rulebase_command = get_relevant_show_rulebase_command(api_call_object)
     if "position" in payload:
         section_name = None
-        if isinstance(payload["position"]) is not dict:
+        if not isinstance(payload["position"], dict):
             position = payload["position"]
             if position == "top":
                 position = 1

plugins/modules/cp_mgmt_simple_cluster.py

@@ -992,28 +992,28 @@
     ip_address: 17.23.5.1
     members:
       - interfaces:
-        - ip_address: 17.23.5.2
-          name: eth0
-          network_mask: 255.255.255.0
-        - ip_address: 1.1.2.4
-          name: eth1
-          network_mask: 255.255.255.0
-        - ip_address: 192.168.1.2
-          name: eth2
-          network_mask: 255.255.255.0
+          - ip_address: 17.23.5.2
+            name: eth0
+            network_mask: 255.255.255.0
+          - ip_address: 1.1.2.4
+            name: eth1
+            network_mask: 255.255.255.0
+          - ip_address: 192.168.1.2
+            name: eth2
+            network_mask: 255.255.255.0
         ip_address: 17.23.5.2
         name: member1
         one_time_password: abcd
       - interfaces:
-        - ip_address: 17.23.5.3
-          name: eth0
-          network_mask: 255.255.255.0
-        - ip_address: 1.1.2.5
-          name: eth1
-          network_mask: 255.255.255.0
-        - ip_address: 192.168.1.3
-          name: eth2
-          network_mask: 255.255.255.0
+          - ip_address: 17.23.5.3
+            name: eth0
+            network_mask: 255.255.255.0
+          - ip_address: 1.1.2.5
+            name: eth1
+            network_mask: 255.255.255.0
+          - ip_address: 192.168.1.3
+            name: eth2
+            network_mask: 255.255.255.0
         ip_address: 17.23.5.3
         name: member2
         one_time_password: abcd

tests/units/plugins/httpapi/test_checkpoint.py

@@ -95,7 +95,7 @@ def _connection_response(response, status=200):
         response_mock = mock.Mock()
         response_mock.getcode.return_value = status
         response_text = (
-            json.dumps(response) if isinstance(response) is dict else response
+            json.dumps(response) if isinstance(response, dict) else response
         )
         response_data = BytesIO(
             response_text.encode() if response_text else "".encode()