Merge pull request #12 from justjais/metaclass_add

Fix validate deprecation and pep8 errors

Author: chkp-orso

plugins/modules/_checkpoint_access_rule.py

@@ -42,11 +42,11 @@
   name:
     description:
     - Name of the access rule.
+    required: true
     type: str
   layer:
     description:
     - Layer to attach the access rule to.
-    required: true
     type: str
   position:
     description:

plugins/modules/_checkpoint_session.py

@@ -89,7 +89,7 @@ def get_session(module, connection):
 
 def main():
     argument_spec = dict(
-        uid=dict(type="str", default=None),
+        uid=dict(type="str", required=True),
         state=dict(
             type="str", default="published", choices=["published", "discarded"]
         ),

plugins/modules/checkpoint_object_facts.py

@@ -40,11 +40,13 @@
     description:
     - UID of the object. If UID is not provided, it will do a full search which can
       be filtered with the filter argument.
+    type: str
   object_filter:
     description:
     - Filter expression for search. It accepts AND/OR logical operators and performs
       a textual and IP address search. To search only by IP address, set ip_only argument
       to True. which can be filtered with the filter argument.
+    type: str
   ip_only:
     description:
     - Filter only by IP address.

plugins/modules/checkpoint_task_facts.py

@@ -75,7 +75,7 @@ def get_task(module, connection):
 
 
 def main():
-    argument_spec = dict(task_id=dict(type="str"))
+    argument_spec = dict(task_id=dict(type="str", required=True))
 
     module = AnsibleModule(argument_spec=argument_spec)
     connection = Connection(module._socket_path)

tests/sanity/ignore-2.10.txt

@@ -0,0 +1,6 @@
+plugins/modules/_checkpoint_access_layer_facts.py validate-modules:deprecation-mismatch
+plugins/modules/_checkpoint_access_rule.py validate-modules:deprecation-mismatch
+plugins/modules/_checkpoint_access_rule_facts.py validate-modules:deprecation-mismatch
+plugins/modules/_checkpoint_host.py validate-modules:deprecation-mismatch
+plugins/modules/_checkpoint_host_facts.py validate-modules:deprecation-mismatch
+plugins/modules/_checkpoint_session.py validate-modules:deprecation-mismatch

tests/units/modules/test_checkpoint_access_rule.py

@@ -16,7 +16,9 @@
 # along with Ansible.  If not, see <http://www.gnu.org/licenses/>.
 #
 
-from __future__ import absolute_import
+from __future__ import absolute_import, division, print_function
+
+__metaclass__ = type
 
 import pytest
 from units.modules.utils import set_module_args, exit_json, fail_json, AnsibleFailJson, AnsibleExitJson
@@ -103,4 +105,3 @@ def _run_module_with_fail_json(self, module_args):
             self.module.main()
         result = exc.value.args[0]
         return result
-