Merge pull request #503 from CesiumGS/ref-counted-impls

j9liu · web-flow · commit b52659506011 · 2024-09-17T17:33:06.000-04:00
Reference counting and accidental copy prevention for Impl classes
diff --git a/Reinterop~/MethodsImplementedInCpp.cs b/Reinterop~/MethodsImplementedInCpp.cs
@@ -33,7 +33,9 @@ public static void Generate(CppGenerationContext context, TypeToGenerate item, G
                     #endif
                     void* {{createName}}(void* handle) {
                       const {{wrapperType.GetFullyQualifiedName()}} wrapper{{{objectHandleType.GetFullyQualifiedName()}}(handle)};
-                      return reinterpret_cast<void*>(new {{implType.GetFullyQualifiedName()}}(wrapper));
+                      auto pImpl = new {{implType.GetFullyQualifiedName()}}(wrapper);
+                      pImpl->addReference();
+                      return reinterpret_cast<void*>(pImpl);
                     }
                     """,
                     TypeDefinitionsReferenced: new[]
@@ -68,7 +70,7 @@ private void CreateImplementation()
                     #endif
                     void {{destroyName}}(void* pImpl) {
                       auto pImplTyped = reinterpret_cast<{{implType.GetFullyQualifiedName()}}*>(pImpl);
-                      delete pImplTyped;
+                      if (pImplTyped) pImplTyped->releaseReference();
                     }
                     """,
                     TypeDefinitionsReferenced: new[]
diff --git a/native~/Editor/src/CesiumEditorWindowImpl.h b/native~/Editor/src/CesiumEditorWindowImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <DotNet/CesiumForUnity/Cesium3DTileset.h>
 #include <DotNet/System/String.h>
 #include <DotNet/UnityEngine/GameObject.h>
@@ -13,7 +15,7 @@ class CesiumEditorWindow;
 
 namespace CesiumForUnityNative {
 
-class CesiumEditorWindowImpl {
+class CesiumEditorWindowImpl : public CesiumImpl<CesiumEditorWindowImpl> {
 
 public:
   CesiumEditorWindowImpl(
diff --git a/native~/Editor/src/CesiumIonSessionImpl.h b/native~/Editor/src/CesiumIonSessionImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumAsync/AsyncSystem.h>
 #include <CesiumAsync/IAssetAccessor.h>
 #include <CesiumAsync/SharedFuture.h>
@@ -33,7 +35,7 @@ class Token;
 } // namespace CesiumIonClient
 
 namespace CesiumForUnityNative {
-class CesiumIonSessionImpl {
+class CesiumIonSessionImpl : public CesiumImpl<CesiumIonSessionImpl> {
 public:
   CesiumIonSessionImpl(const DotNet::CesiumForUnity::CesiumIonSession& session);
   ~CesiumIonSessionImpl();
diff --git a/native~/Editor/src/IonAssetsTreeViewImpl.h b/native~/Editor/src/IonAssetsTreeViewImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumIonClient/Assets.h>
 
 #include <DotNet/CesiumForUnity/IonAssetsColumn.h>
@@ -15,7 +17,7 @@ class IonAssetsTreeView;
 
 namespace CesiumForUnityNative {
 
-class IonAssetsTreeViewImpl {
+class IonAssetsTreeViewImpl : public CesiumImpl<IonAssetsTreeViewImpl> {
 public:
   IonAssetsTreeViewImpl(
       const DotNet::CesiumForUnity::IonAssetsTreeView& treeView);
diff --git a/native~/Editor/src/SelectIonTokenWindowImpl.h b/native~/Editor/src/SelectIonTokenWindowImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumAsync/AsyncSystem.h>
 #include <CesiumIonClient/Token.h>
 
@@ -17,7 +19,7 @@ class CesiumIonServer;
 
 namespace CesiumForUnityNative {
 
-class SelectIonTokenWindowImpl {
+class SelectIonTokenWindowImpl : public CesiumImpl<SelectIonTokenWindowImpl> {
 
 public:
   static CesiumAsync::SharedFuture<std::optional<CesiumIonClient::Token>>
diff --git a/native~/Runtime/src/Cesium3DTilesetImpl.h b/native~/Runtime/src/Cesium3DTilesetImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <Cesium3DTilesSelection/ViewUpdateResult.h>
 
 #include <DotNet/CesiumForUnity/CesiumCreditSystem.h>
@@ -25,7 +27,7 @@ class Tileset;
 
 namespace CesiumForUnityNative {
 
-class Cesium3DTilesetImpl {
+class Cesium3DTilesetImpl : public CesiumImpl<Cesium3DTilesetImpl> {
 public:
   Cesium3DTilesetImpl(const DotNet::CesiumForUnity::Cesium3DTileset& tileset);
   ~Cesium3DTilesetImpl();
diff --git a/native~/Runtime/src/CesiumBingMapsRasterOverlayImpl.h b/native~/Runtime/src/CesiumBingMapsRasterOverlayImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/IntrusivePointer.h>
 
 namespace DotNet::CesiumForUnity {
@@ -13,7 +15,8 @@ class BingMapsRasterOverlay;
 
 namespace CesiumForUnityNative {
 
-class CesiumBingMapsRasterOverlayImpl {
+class CesiumBingMapsRasterOverlayImpl
+    : public CesiumImpl<CesiumBingMapsRasterOverlayImpl> {
 public:
   CesiumBingMapsRasterOverlayImpl(
       const DotNet::CesiumForUnity::CesiumBingMapsRasterOverlay& overlay);
diff --git a/native~/Runtime/src/CesiumCreditSystemImpl.h b/native~/Runtime/src/CesiumCreditSystemImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/CreditSystem.h>
 
 #include <DotNet/CesiumForUnity/CesiumCredit.h>
@@ -21,7 +23,7 @@ struct Credit;
 
 namespace CesiumForUnityNative {
 
-class CesiumCreditSystemImpl {
+class CesiumCreditSystemImpl : public CesiumImpl<CesiumCreditSystemImpl> {
 public:
   CesiumCreditSystemImpl(
       const DotNet::CesiumForUnity::CesiumCreditSystem& creditSystem);
diff --git a/native~/Runtime/src/CesiumDebugColorizeTilesRasterOverlayImpl.h b/native~/Runtime/src/CesiumDebugColorizeTilesRasterOverlayImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/IntrusivePointer.h>
 
 namespace DotNet::CesiumForUnity {
@@ -13,7 +15,8 @@ class DebugColorizeTilesRasterOverlay;
 
 namespace CesiumForUnityNative {
 
-class CesiumDebugColorizeTilesRasterOverlayImpl {
+class CesiumDebugColorizeTilesRasterOverlayImpl
+    : public CesiumImpl<CesiumDebugColorizeTilesRasterOverlayImpl> {
 public:
   CesiumDebugColorizeTilesRasterOverlayImpl(
       const DotNet::CesiumForUnity::CesiumDebugColorizeTilesRasterOverlay&
diff --git a/native~/Runtime/src/CesiumEllipsoidImpl.h b/native~/Runtime/src/CesiumEllipsoidImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumGeospatial/Ellipsoid.h>
 
 #include <DotNet/Unity/Mathematics/double3.h>
@@ -12,7 +14,7 @@ class CesiumEllipsoid;
 
 namespace CesiumForUnityNative {
 
-class CesiumEllipsoidImpl {
+class CesiumEllipsoidImpl : public CesiumImpl<CesiumEllipsoidImpl> {
 public:
   CesiumEllipsoidImpl(
       const DotNet::CesiumForUnity::CesiumEllipsoid& unityEllipsoid);
diff --git a/native~/Runtime/src/CesiumFeatureIdAttributeImpl.h b/native~/Runtime/src/CesiumFeatureIdAttributeImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumGltf/AccessorUtility.h>
 
 namespace DotNet::CesiumForUnity {
@@ -12,7 +14,8 @@ struct MeshPrimitive;
 } // namespace CesiumGltf
 
 namespace CesiumForUnityNative {
-class CesiumFeatureIdAttributeImpl {
+class CesiumFeatureIdAttributeImpl
+    : public CesiumImpl<CesiumFeatureIdAttributeImpl> {
 public:
   CesiumFeatureIdAttributeImpl(
       const DotNet::CesiumForUnity::CesiumFeatureIdAttribute&
diff --git a/native~/Runtime/src/CesiumFeatureIdTextureImpl.h b/native~/Runtime/src/CesiumFeatureIdTextureImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumGltf/AccessorUtility.h>
 #include <CesiumGltf/FeatureIdTextureView.h>
 
@@ -19,7 +21,8 @@ struct FeatureIdTexture;
 } // namespace CesiumGltf
 
 namespace CesiumForUnityNative {
-class CesiumFeatureIdTextureImpl {
+class CesiumFeatureIdTextureImpl
+    : public CesiumImpl<CesiumFeatureIdTextureImpl> {
 public:
   CesiumFeatureIdTextureImpl(
       const DotNet::CesiumForUnity::CesiumFeatureIdTexture& featureIdTexture);
diff --git a/native~/Runtime/src/CesiumFeatureImpl.h b/native~/Runtime/src/CesiumFeatureImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumGltf/PropertyTablePropertyView.h>
 
 #include <DotNet/CesiumForUnity/CesiumMetadataValue.h>
@@ -44,7 +46,7 @@ using ValueType = swl::variant<
     CesiumGltf::PropertyArrayView<bool>,
     CesiumGltf::PropertyArrayView<std::string_view>>;
 
-class CesiumFeatureImpl {
+class CesiumFeatureImpl : public CesiumImpl<CesiumFeatureImpl> {
 public:
   CesiumFeatureImpl(const DotNet::CesiumForUnity::CesiumFeature& feature);
   ~CesiumFeatureImpl();
diff --git a/native~/Runtime/src/CesiumGeoreferenceImpl.h b/native~/Runtime/src/CesiumGeoreferenceImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumGeospatial/LocalHorizontalCoordinateSystem.h>
 
 #include <DotNet/Unity/Mathematics/double3.h>
@@ -16,7 +18,7 @@ class Transform;
 }
 
 namespace CesiumForUnityNative {
-class CesiumGeoreferenceImpl {
+class CesiumGeoreferenceImpl : public CesiumImpl<CesiumGeoreferenceImpl> {
 public:
   CesiumGeoreferenceImpl(
       const DotNet::CesiumForUnity::CesiumGeoreference& georeference);
diff --git a/native~/Runtime/src/CesiumIonRasterOverlayImpl.h b/native~/Runtime/src/CesiumIonRasterOverlayImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/IntrusivePointer.h>
 
 namespace DotNet::CesiumForUnity {
@@ -13,7 +15,8 @@ class IonRasterOverlay;
 
 namespace CesiumForUnityNative {
 
-class CesiumIonRasterOverlayImpl {
+class CesiumIonRasterOverlayImpl
+    : public CesiumImpl<CesiumIonRasterOverlayImpl> {
 public:
   CesiumIonRasterOverlayImpl(
       const DotNet::CesiumForUnity::CesiumIonRasterOverlay& overlay);
diff --git a/native~/Runtime/src/CesiumMetadataImpl.h b/native~/Runtime/src/CesiumMetadataImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumGltf/AccessorUtility.h>
 #include <CesiumGltf/Model.h>
 
@@ -21,7 +23,7 @@ class Transform;
 
 namespace CesiumForUnityNative {
 
-class CesiumMetadataImpl {
+class CesiumMetadataImpl : public CesiumImpl<CesiumMetadataImpl> {
 public:
   CesiumMetadataImpl(const DotNet::CesiumForUnity::CesiumMetadata& metadata);
   ~CesiumMetadataImpl();
diff --git a/native~/Runtime/src/CesiumPolygonRasterOverlayImpl.h b/native~/Runtime/src/CesiumPolygonRasterOverlayImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/IntrusivePointer.h>
 
 #include <DotNet/System/Collections/Generic/List1.h>
@@ -25,7 +27,8 @@ class CartographicPolygon;
 
 namespace CesiumForUnityNative {
 
-class CesiumPolygonRasterOverlayImpl {
+class CesiumPolygonRasterOverlayImpl
+    : public CesiumImpl<CesiumPolygonRasterOverlayImpl> {
 public:
   CesiumPolygonRasterOverlayImpl(
       const DotNet::CesiumForUnity::CesiumPolygonRasterOverlay& overlay);
diff --git a/native~/Runtime/src/CesiumPropertyTablePropertyImpl.h b/native~/Runtime/src/CesiumPropertyTablePropertyImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <any>
 #include <cstdint>
 #include <unordered_map>
@@ -43,7 +45,8 @@ class double4x4;
 
 namespace CesiumForUnityNative {
 
-class CesiumPropertyTablePropertyImpl {
+class CesiumPropertyTablePropertyImpl
+    : public CesiumImpl<CesiumPropertyTablePropertyImpl> {
 public:
   CesiumPropertyTablePropertyImpl(
       const DotNet::CesiumForUnity::CesiumPropertyTableProperty& property);
diff --git a/native~/Runtime/src/CesiumSimplePlanarEllipsoidCurveImpl.h b/native~/Runtime/src/CesiumSimplePlanarEllipsoidCurveImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumGeospatial/SimplePlanarEllipsoidCurve.h>
 
 #include <DotNet/CesiumForUnity/CesiumEllipsoid.h>
@@ -17,7 +19,8 @@ struct double3;
 
 namespace CesiumForUnityNative {
 
-class CesiumSimplePlanarEllipsoidCurveImpl {
+class CesiumSimplePlanarEllipsoidCurveImpl
+    : public CesiumImpl<CesiumSimplePlanarEllipsoidCurveImpl> {
 public:
   CesiumSimplePlanarEllipsoidCurveImpl(
       const DotNet::CesiumForUnity::CesiumSimplePlanarEllipsoidCurve& path);
diff --git a/native~/Runtime/src/CesiumTileMapServiceRasterOverlayImpl.h b/native~/Runtime/src/CesiumTileMapServiceRasterOverlayImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/IntrusivePointer.h>
 
 namespace DotNet::CesiumForUnity {
@@ -13,7 +15,8 @@ class TileMapServiceRasterOverlay;
 
 namespace CesiumForUnityNative {
 
-class CesiumTileMapServiceRasterOverlayImpl {
+class CesiumTileMapServiceRasterOverlayImpl
+    : public CesiumImpl<CesiumTileMapServiceRasterOverlayImpl> {
 public:
   CesiumTileMapServiceRasterOverlayImpl(
       const DotNet::CesiumForUnity::CesiumTileMapServiceRasterOverlay& overlay);
diff --git a/native~/Runtime/src/CesiumWebMapServiceRasterOverlayImpl.h b/native~/Runtime/src/CesiumWebMapServiceRasterOverlayImpl.h
@@ -1,5 +1,7 @@
 #pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/IntrusivePointer.h>
 
 namespace DotNet::CesiumForUnity {
@@ -13,7 +15,8 @@ class WebMapServiceRasterOverlay;
 
 namespace CesiumForUnityNative {
 
-class CesiumWebMapServiceRasterOverlayImpl {
+class CesiumWebMapServiceRasterOverlayImpl
+    : public CesiumImpl<CesiumWebMapServiceRasterOverlayImpl> {
 public:
   CesiumWebMapServiceRasterOverlayImpl(
       const DotNet::CesiumForUnity::CesiumWebMapServiceRasterOverlay& overlay);
diff --git a/native~/Runtime/src/CesiumWebMapTileServiceRasterOverlayImpl.h b/native~/Runtime/src/CesiumWebMapTileServiceRasterOverlayImpl.h
@@ -1,5 +1,7 @@
 ﻿#pragma once
 
+#include "CesiumImpl.h"
+
 #include <CesiumUtility/IntrusivePointer.h>
 
 namespace DotNet::CesiumForUnity {
@@ -13,7 +15,8 @@ class WebMapTileServiceRasterOverlay;
 
 namespace CesiumForUnityNative {
 
-class CesiumWebMapTileServiceRasterOverlayImpl {
+class CesiumWebMapTileServiceRasterOverlayImpl
+    : public CesiumImpl<CesiumWebMapTileServiceRasterOverlayImpl> {
 public:
   CesiumWebMapTileServiceRasterOverlayImpl(
       const DotNet::CesiumForUnity::CesiumWebMapTileServiceRasterOverlay&
diff --git a/native~/Runtime/src/TestGltfModelImpl.h b/native~/Runtime/src/TestGltfModelImpl.h
diff --git a/native~/Shared/src/CesiumImpl.h b/native~/Shared/src/CesiumImpl.h
diff --git a/native~/Shared/src/NativeDownloadHandlerImpl.h b/native~/Shared/src/NativeDownloadHandlerImpl.h
