Unify Github issue links in diagnostics

eupn · punitkoura · eupn · commit 01f97c323fe0 · 2019-07-31T15:20:25.000+07:00
Co-authored-by: eupn &lt;eupn@protonmail.com&gt;
Co-authored-by: Punit Singh Koura &lt;pkoura@andrew.cmu.edu&gt;
diff --git a/src/librustc/lint/mod.rs b/src/librustc/lint/mod.rs
@@ -737,7 +737,7 @@ pub fn struct_lint_level<'a>(sess: &'a Session,
         } else {
             format!("{} in a future release!", STANDARD_MESSAGE)
         };
-        let citation = format!("for more information, see {}",
+        let citation = format!("see {} for more information",
                                future_incompatible.reference);
         err.warn(&explanation);
         err.note(&citation);
diff --git a/src/librustc/session/mod.rs b/src/librustc/session/mod.rs
@@ -1317,7 +1317,7 @@ fn validate_commandline_args_with_session_available(sess: &Session) {
        sess.opts.prints.iter().all(|&p| p == PrintRequest::NativeStaticLibs) {
         sess.err("Profile-guided optimization does not yet work in conjunction \
                   with `-Cpanic=unwind` on Windows when targeting MSVC. \
-                  See https://github.com/rust-lang/rust/issues/61002 for details.");
+                  See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for details.");
     }
 }
 
diff --git a/src/librustc/traits/error_reporting.rs b/src/librustc/traits/error_reporting.rs
@@ -729,7 +729,7 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {
                                 err.note("the trait is implemented for `()`. \
                                          Possibly this error has been caused by changes to \
                                          Rust's type-inference algorithm \
-                                         (see: https://github.com/rust-lang/rust/issues/48950 \
+                                         (see issue #48950 <https://github.com/rust-lang/rust/issues/48950> \
                                          for more info). Consider whether you meant to use the \
                                          type `()` here instead.");
                             }
diff --git a/src/librustc/ty/error.rs b/src/librustc/ty/error.rs
@@ -287,7 +287,8 @@ impl<'tcx> TyCtxt<'tcx> {
                 if ty.is_closure() || ty.is_generator() {
                     db.note("closures cannot capture themselves or take themselves as argument;\n\
                              this error may be the result of a recent compiler bug-fix,\n\
-                             see https://github.com/rust-lang/rust/issues/46062 for more details");
+                             see issue #46062 <https://github.com/rust-lang/rust/issues/46062> \
+                             for more information");
                 }
             }
             _ => {}
diff --git a/src/librustc_lint/lib.rs b/src/librustc_lint/lib.rs
@@ -457,37 +457,37 @@ pub fn register_builtins(store: &mut lint::LintStore, sess: Option<&Session>) {
     store.register_removed("transmute_from_fn_item_types",
         "always cast functions before transmuting them");
     store.register_removed("hr_lifetime_in_assoc_type",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/33685");
+        "converted into hard error, see issue #33685 <https://github.com/rust-lang/rust/issues/33685>");
     store.register_removed("inaccessible_extern_crate",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/36886");
+        "converted into hard error, see issue #36886 <https://github.com/rust-lang/rust/issues/36886>");
     store.register_removed("super_or_self_in_global_path",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/36888");
+        "converted into hard error, see issue #36888 <https://github.com/rust-lang/rust/issues/36888>");
     store.register_removed("overlapping_inherent_impls",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/36889");
+        "converted into hard error, see issue #36889 <https://github.com/rust-lang/rust/issues/36889>");
     store.register_removed("illegal_floating_point_constant_pattern",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/36890");
+        "converted into hard error, see issue #36890 <https://github.com/rust-lang/rust/issues/36890>");
     store.register_removed("illegal_struct_or_enum_constant_pattern",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/36891");
+        "converted into hard error, see issue #36891 <https://github.com/rust-lang/rust/issues/36891>");
     store.register_removed("lifetime_underscore",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/36892");
+        "converted into hard error, see issue #36892 <https://github.com/rust-lang/rust/issues/36892>");
     store.register_removed("extra_requirement_in_impl",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/37166");
+        "converted into hard error, see issue #37166 <https://github.com/rust-lang/rust/issues/37166>");
     store.register_removed("legacy_imports",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/38260");
+        "converted into hard error, see issue #38260 <https://github.com/rust-lang/rust/issues/38260>");
     store.register_removed("coerce_never",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/48950");
+        "converted into hard error, see issue #48950 <https://github.com/rust-lang/rust/issues/48950>");
     store.register_removed("resolve_trait_on_defaulted_unit",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/48950");
+        "converted into hard error, see issue #48950 <https://github.com/rust-lang/rust/issues/48950>");
     store.register_removed("private_no_mangle_fns",
         "no longer a warning, `#[no_mangle]` functions always exported");
     store.register_removed("private_no_mangle_statics",
         "no longer a warning, `#[no_mangle]` statics always exported");
     store.register_removed("bad_repr",
         "replaced with a generic attribute input check");
     store.register_removed("duplicate_matcher_binding_name",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/57742");
+        "converted into hard error, see issue #57742 <https://github.com/rust-lang/rust/issues/57742>");
     store.register_removed("incoherent_fundamental_impls",
-        "converted into hard error, see https://github.com/rust-lang/rust/issues/46205");
+        "converted into hard error, see issue #46205 <https://github.com/rust-lang/rust/issues/46205>");
 }
 
 pub fn register_internals(store: &mut lint::LintStore, sess: Option<&Session>) {
diff --git a/src/librustc_mir/transform/qualify_consts.rs b/src/librustc_mir/transform/qualify_consts.rs
@@ -1623,8 +1623,9 @@ impl MirPass for QualifyAndPromoteConstants {
                                 "{}",
                                 err,
                             );
-                            diag.note("for more information, see issue \
-                                       https://github.com/rust-lang/rust/issues/57563");
+                            diag.note("see issue \
+                                      #57563 <https://github.com/rust-lang/rust/issues/57563> \
+                                      for more information");
                             diag.help(
                                 "add `#![feature(const_fn)]` to the crate attributes to enable",
                             );
@@ -1667,7 +1668,7 @@ impl MirPass for QualifyAndPromoteConstants {
                             *span,
                             &format!("use of {} here does not actually short circuit due to \
                             the const evaluator presently not being able to do control flow. \
-                            See https://github.com/rust-lang/rust/issues/49146 for more \
+                            See issue #49146 <https://github.com/rust-lang/rust/issues/49146> for more \
                             information.", kind),
                         );
                     }
diff --git a/src/librustc_typeck/check/demand.rs b/src/librustc_typeck/check/demand.rs
@@ -728,7 +728,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {
                         err.warn("if the rounded value cannot be represented by the target \
                                   integer type, including `Inf` and `NaN`, casting will cause \
                                   undefined behavior \
-                                  (https://github.com/rust-lang/rust/issues/10184)");
+                                  see issue #10184 <https://github.com/rust-lang/rust/issues/10184>");
                     }
                     true
                 }
diff --git a/src/librustc_typeck/check/mod.rs b/src/librustc_typeck/check/mod.rs
@@ -4528,7 +4528,7 @@ fn fatally_break_rust(sess: &Session) {
     handler.note_without_error("the compiler expectedly panicked. this is a feature.");
     handler.note_without_error(
         "we would appreciate a joke overview: \
-        https://github.com/rust-lang/rust/issues/43162#issuecomment-320764675"
+        see issue #43162 <https://github.com/rust-lang/rust/issues/43162#issuecomment-320764675>"
     );
     handler.note_without_error(&format!("rustc {} running on {}",
         option_env!("CFG_VERSION").unwrap_or("unknown_version"),
diff --git a/src/librustdoc/config.rs b/src/librustdoc/config.rs
@@ -518,7 +518,7 @@ fn check_deprecated_options(matches: &getopts::Matches, diag: &errors::Handler)
         if matches.opt_present(flag) {
             let mut err = diag.struct_warn(&format!("the '{}' flag is considered deprecated",
                                                     flag));
-            err.warn("please see https://github.com/rust-lang/rust/issues/44136");
+            err.warn("please see issue #44136 <https://github.com/rust-lang/rust/issues/44136>");
 
             if *flag == "no-defaults" {
                 err.help("you may want to use --document-private-items");
diff --git a/src/librustdoc/core.rs b/src/librustdoc/core.rs
@@ -402,7 +402,7 @@ pub fn run_core(options: RustdocOptions) -> (clean::Crate, RenderInfo, RenderOpt
             fn report_deprecated_attr(name: &str, diag: &errors::Handler) {
                 let mut msg = diag.struct_warn(&format!("the `#![doc({})]` attribute is \
                                                          considered deprecated", name));
-                msg.warn("please see https://github.com/rust-lang/rust/issues/44136");
+                msg.warn("please see issue #44136 <https://github.com/rust-lang/rust/issues/44136>");
 
                 if name == "no_default_passes" {
                     msg.help("you may want to use `#![doc(document_private_items)]`");
diff --git a/src/libsyntax/feature_gate.rs b/src/libsyntax/feature_gate.rs
@@ -1391,7 +1391,7 @@ pub const BUILTIN_ATTRIBUTES: &[BuiltinAttribute] = &[
     (sym::link_section, Whitelisted, template!(NameValueStr: "name"), Ungated),
     (sym::no_builtins, Whitelisted, template!(Word), Ungated),
     (sym::no_debug, Whitelisted, template!(Word), Gated(
-        Stability::Deprecated("https://github.com/rust-lang/rust/issues/29721", None),
+        Stability::Deprecated("issue #29721 <https://github.com/rust-lang/rust/issues/29721>", None),
         sym::no_debug,
         "the `#[no_debug]` attribute was an experimental feature that has been \
         deprecated due to lack of demand",
@@ -1748,7 +1748,9 @@ fn leveled_feature_err<'a, S: Into<MultiSpan>>(
         None | Some(0) => {}  // We still accept `0` as a stand-in for backwards compatibility
         Some(n) => {
             err.note(&format!(
-                "for more information, see https://github.com/rust-lang/rust/issues/{}",
+                "see issue #{} <https://github.com/rust-lang/rust/issues/{}> \
+                for more information",
+                n,
                 n,
             ));
         }
diff --git a/src/libsyntax/parse/diagnostics.rs b/src/libsyntax/parse/diagnostics.rs
@@ -411,8 +411,8 @@ impl<'a> Parser<'a> {
             } else {
                 err.note("`#![feature(type_ascription)]` lets you annotate an expression with a \
                           type: `<expr>: <type>`");
-                err.note("for more information, see \
-                          https://github.com/rust-lang/rust/issues/23416");
+                err.note("see issue #23416 <https://github.com/rust-lang/rust/issues/23416> \
+                for more information");
             }
         }
     }
diff --git a/src/libsyntax/parse/lexer/mod.rs b/src/libsyntax/parse/lexer/mod.rs
@@ -303,8 +303,9 @@ impl<'a> StringReader<'a> {
                             .warn("this was previously accepted by the compiler but is \
                                    being phased out; it will become a hard error in \
                                    a future release!")
-                            .note("for more information, see issue #42326 \
-                                   <https://github.com/rust-lang/rust/issues/42326>")
+                            .note("see issue \
+                                  #42326 <https://github.com/rust-lang/rust/issues/42326> \
+                                  for more information")
                             .emit();
                         None
                     } else {
diff --git a/src/libsyntax/parse/literal.rs b/src/libsyntax/parse/literal.rs
@@ -373,7 +373,8 @@ crate fn expect_no_suffix(diag: &Handler, sp: Span, kind: &str, suffix: Option<S
                     to tuple field access",
             );
             err.note(
-                "for more context, see https://github.com/rust-lang/rust/issues/60210",
+                "see issue #60210 <https://github.com/rust-lang/rust/issues/60210> \
+                for more information",
             );
             err
         } else {
diff --git a/src/test/ui/consts/const-eval/match-test-ptr-null.rs b/src/test/ui/consts/const-eval/match-test-ptr-null.rs
@@ -5,7 +5,7 @@ fn main() {
     let _: [u8; 0] = [4; {
         match &1 as *const i32 as usize {
             //~^ ERROR casting pointers to integers in constants
-            //~| NOTE for more information, see
+            //~| NOTE see issue #
             //~| ERROR constant contains unimplemented expression type
             0 => 42, //~ ERROR constant contains unimplemented expression type
             //~^ NOTE "pointer arithmetic or comparison" needs an rfc before being allowed

Original file line number	Diff line number	Diff line change
`@@ -1317,7 +1317,7 @@ fn validate_commandline_args_with_session_available(sess: &Session) {`
`1317`	`1317`	`sess.opts.prints.iter().all(\|&p\| p == PrintRequest::NativeStaticLibs) {`
`1318`	`1318`	`sess.err("Profile-guided optimization does not yet work in conjunction \`
`1319`	`1319`	with `-Cpanic=unwind` on Windows when targeting MSVC. \
`1320`		`- See https://github.com/rust-lang/rust/issues/61002 for details.");`
	`1320`	`+ See issue #61002 <https://github.com/rust-lang/rust/issues/61002> for details.");`
`1321`	`1321`	`}`
`1322`	`1322`	`}`
`1323`	`1323`
Original file line number	Diff line number	Diff line change
`@@ -729,7 +729,7 @@ impl<'a, 'tcx> InferCtxt<'a, 'tcx> {`
`729`	`729`	err.note("the trait is implemented for `()`. \
`730`	`730`	`Possibly this error has been caused by changes to \`
`731`	`731`	`Rust's type-inference algorithm \`
`732`		`- (see: https://github.com/rust-lang/rust/issues/48950 \`
	`732`	`+ (see issue #48950 <https://github.com/rust-lang/rust/issues/48950> \`
`733`	`733`	`for more info). Consider whether you meant to use the \`
`734`	`734`	type `()` here instead.");
`735`	`735`	`}`
Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,8 @@ impl<'tcx> TyCtxt<'tcx> {`
`287`	`287`	`if ty.is_closure() \|\| ty.is_generator() {`
`288`	`288`	`db.note("closures cannot capture themselves or take themselves as argument;\n\`
`289`	`289`	`this error may be the result of a recent compiler bug-fix,\n\`
`290`		`- see https://github.com/rust-lang/rust/issues/46062 for more details");`
	`290`	`+ see issue #46062 <https://github.com/rust-lang/rust/issues/46062> \`
	`291`	`+ for more information");`
`291`	`292`	`}`
`292`	`293`	`}`
`293`	`294`	`_ => {}`
Original file line number	Diff line number	Diff line change
`@@ -728,7 +728,7 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> {`
`728`	`728`	`err.warn("if the rounded value cannot be represented by the target \`
`729`	`729`	integer type, including `Inf` and `NaN`, casting will cause \
`730`	`730`	`undefined behavior \`
`731`		`- (https://github.com/rust-lang/rust/issues/10184)");`
	`731`	`+ see issue #10184 <https://github.com/rust-lang/rust/issues/10184>");`
`732`	`732`	`}`
`733`	`733`	`true`
`734`	`734`	`}`