Skip to content

Commit ed05e0b

Browse files
committed
Deduplicate names seperately before building fullname
1 parent cbca429 commit ed05e0b

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

api/institutions/authentication.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -224,15 +224,16 @@ def authenticate(self, request):
224224
f'sso_email={sso_email}, sso_identity={sso_identity}]',
225225
)
226226

227-
# Deduplicate full name first if it is provided
227+
# Deduplicate names first if it is provided
228228
if fullname:
229229
fullname = deduplicate_sso_attributes('fullname', fullname)
230-
# Use given name and family name to build full name if it is not provided
231-
if given_name and family_name and not fullname:
230+
if given_name:
232231
given_name = deduplicate_sso_attributes('given_name', given_name)
232+
if family_name:
233233
family_name = deduplicate_sso_attributes('family_name', family_name)
234+
# Use given name and family name to build full name if it is not provided
235+
if given_name and family_name and not fullname:
234236
fullname = given_name + ' ' + family_name
235-
236237
# Non-empty full name is required. Fail the auth and inform sentry if not provided.
237238
if not fullname:
238239
message = f'Institution SSO Error: missing full name ' \

0 commit comments

Comments
 (0)