fix unit tests

Author: Ostap-Zherebetskyi

addons/base/views.py

@@ -611,7 +611,6 @@ def create_waterbutler_log(payload, **kwargs):
     target_node = AbstractNode.load(metadata.get('nid'))
     if target_node and payload['action'] != 'download_file':
         update_storage_usage_with_size(payload)
-
     with transaction.atomic():
         file_signals.file_updated.send(target=node, user=user, event_type=action, payload=payload)
     return {'status': 'success'}

tests/test_addons.py

@@ -1569,7 +1569,7 @@ def test_delete_action_creates_trashed_file_node(self):
                 'materialized': '/test/Test'
             }
         }
-        views.addon_delete_file_node(self=None, target=self.project, user=self.user, payload=payload)
+        views.addon_delete_file_node(self=None, target=self.project, user=self.user, event_type='file_removed', payload=payload)
         assert not GithubFileNode.load(file_node._id)
         assert TrashedFileNode.load(file_node._id)
 
@@ -1590,7 +1590,7 @@ def test_delete_action_for_folder_deletes_subfolders_and_creates_trashed_file_no
                 'materialized': '/test/'
             }
         }
-        views.addon_delete_file_node(self=None, target=self.project, user=self.user, payload=payload)
+        views.addon_delete_file_node(self=None, target=self.project, user=self.user, event_type='file_removed', payload=payload)
         assert not GithubFileNode.load(subfolder._id)
         assert TrashedFileNode.load(file_node._id)
 

tests/test_preprints.py

@@ -2174,8 +2174,7 @@ def test_add_log(self):
         url = self.preprint.api_url_for('create_waterbutler_log')
         payload = self.build_payload(metadata={'nid': self.preprint._id, 'materialized': path, 'kind': 'file', 'path': path})
         nlogs = self.preprint.logs.count()
-        with capture_notifications():
-            self.app.put(url, json=payload)
+        self.app.put(url, json=payload)
         self.preprint.reload()
         assert self.preprint.logs.count() == nlogs + 1
 
@@ -2244,14 +2243,11 @@ def test_action_file_rename(self):
                 'kind': 'file',
             },
         )
-        with capture_notifications() as notifications:
-            self.app.put(
-                url,
-                json=payload,
-            )
+        self.app.put(
+            url,
+            json=payload,
+        )
         self.preprint.reload()
-        assert len(notifications['emits']) == 1
-        assert notifications['emits'][0]['type'] == NotificationType.Type.ADDON_FILE_RENAMED
         assert self.preprint.logs.latest().action == 'osf_storage_addon_file_renamed'
 
     def test_action_downloads_contrib(self):
@@ -2279,11 +2275,8 @@ def test_add_file_osfstorage_log(self):
         url = self.preprint.api_url_for('create_waterbutler_log')
         payload = self.build_payload(metadata={'nid': self.preprint._id, 'materialized': path, 'kind': 'file', 'path': path})
         nlogs = self.preprint.logs.count()
-        with capture_notifications() as notifications:
-            self.app.put(url, json=payload)
+        self.app.put(url, json=payload)
         self.preprint.reload()
-        assert len(notifications['emits']) == 1
-        assert notifications['emits'][0]['type'] == NotificationType.Type.FILE_ADDED
         assert self.preprint.logs.count() == nlogs + 1
         assert ('urls' in self.preprint.logs.filter(action='osf_storage_file_added')[0].params)
 
@@ -2292,11 +2285,8 @@ def test_add_folder_osfstorage_log(self):
         url = self.preprint.api_url_for('create_waterbutler_log')
         payload = self.build_payload(metadata={'nid': self.preprint._id, 'materialized': path, 'kind': 'folder', 'path': path})
         nlogs = self.preprint.logs.count()
-        with capture_notifications() as notifications:
-            self.app.put(url, json=payload)
+        self.app.put(url, json=payload)
         self.preprint.reload()
-        assert len(notifications['emits']) == 1
-        assert notifications['emits'][0]['type'] == NotificationType.Type.FILE_ADDED
         assert self.preprint.logs.count() == nlogs + 1
         assert ('urls' not in self.preprint.logs.filter(action='osf_storage_file_added')[0].params)