[ENG-9122] Update fix (#11403)

Author: Vlad0n20

osf/models/preprint.py

@@ -382,14 +382,18 @@ def create(cls, provider, title, creator, description, manual_guid=None, manual_
 
     def get_last_not_rejected_version(self):
         """Get the last version that is not rejected.
+        Returns None if all versions are rejected.
         """
-        return self.get_guid().versions.filter(is_rejected=False).order_by('-version').first().referent
+        last_not_rejected = self.get_guid().versions.filter(is_rejected=False).order_by('-version').first()
+        return last_not_rejected.referent if last_not_rejected else None
 
     def has_unpublished_pending_version(self):
         """Check if preprint has pending unpublished version.
         Note: use `.check_unfinished_or_unpublished_version()` if checking both types
         """
         last_not_rejected_version = self.get_last_not_rejected_version()
+        if not last_not_rejected_version:
+            return False
         return not last_not_rejected_version.date_published and last_not_rejected_version.machine_state == 'pending'
 
     def has_initiated_but_unfinished_version(self):
@@ -800,7 +804,7 @@ def date_created_first_version(self):
             if not base_guid:
                 return self.created
 
-            first_version = base_guid.versions.filter(is_rejected=False).order_by('version').first()
+            first_version = base_guid.versions.order_by('version').first()
 
             if first_version and first_version.referent:
                 return first_version.referent.created

tests/test_preprints.py

@@ -2701,6 +2701,38 @@ def test_preprint_version_withdrawal_request_post_mod(self, make_withdrawal_requ
         assert new_version.is_published is True
         assert new_version.machine_state == ReviewStates.WITHDRAWN.value
 
+    def test_date_created_first_version_with_rejected_v1(self, creator, moderator):
+        v1 = PreprintFactory(reviews_workflow='pre-moderation', is_published=False, creator=creator)
+        v1.run_submit(creator)
+        v1.run_reject(moderator, 'Rejecting v1')
+        v1.reload()
+
+        assert v1.machine_state == ReviewStates.REJECTED.value
+        assert v1.versioned_guids.first().is_rejected is True
+        v1_created = v1.created
+
+        v2 = PreprintFactory.create_version(
+            create_from=v1,
+            creator=creator,
+            final_machine_state='initial',
+            is_published=False,
+            set_doi=False
+        )
+        v2.run_submit(creator)
+        v2.run_accept(moderator, 'Accepting v2')
+        v2.reload()
+
+        assert v2.machine_state == ReviewStates.ACCEPTED.value
+        assert v2.is_published is True
+        v2_created = v2.created
+
+        assert v2_created > v1_created
+
+        assert v2.date_created_first_version == v1_created
+        assert v2.date_created_first_version != v2_created
+
+        assert v1.date_created_first_version == v1_created
+
 
 class TestEmberRedirect(OsfTestCase):