Merge pull request #11265 from antkryt/fix/ENG-8656

[ENG-8656] Clean up password reset throttle error

Author: Johnetordoff

api_tests/users/views/test_user_settings.py

@@ -10,6 +10,7 @@
     UserFactory,
 )
 from django.middleware import csrf
+from django.core.cache import cache
 from osf.models import Email, NotableDomain
 from framework.auth.views import auth_email_logout
 from website import mails, settings
@@ -189,6 +190,10 @@ def url(self):
     def csrf_token(self):
         return csrf._mask_cipher_secret(csrf._get_new_csrf_string())
 
+    @pytest.fixture(autouse=True)
+    def clear_throttle_cache(self):
+        cache.clear()
+
     def test_get(self, app, url, user_one):
         encoded_email = urllib.parse.quote(user_one.email)
         url = f'{url}?email={encoded_email}'
@@ -275,7 +280,7 @@ def test_post_invalid_password(self, app, url, user_one, csrf_token):
         res = app.post_json_api(url, payload, expect_errors=True, headers={'X-THROTTLE-TOKEN': 'test-token', 'X-CSRFToken': csrf_token})
         assert res.status_code == 400
 
-    def test_throrrle(self, app, url, user_one):
+    def test_throttle(self, app, url, user_one):
         encoded_email = urllib.parse.quote(user_one.email)
         url = f'{url}?email={encoded_email}'
         res = app.get(url)
@@ -290,10 +295,11 @@ def test_throrrle(self, app, url, user_one):
             }
         }
 
-        res = app.post_json_api(url, payload, expect_errors=True)
-        assert res.status_code == 429
+        res = app.post_json_api(url, payload, expect_errors=False)
+        assert res.status_code == 200
 
         res = app.get(url, expect_errors=True)
+        assert res.status_code == 429
         assert res.json['message'] == 'You have recently requested to change your password. Please wait a few minutes before trying again.'