[ENG-4053] Update registration finalize modal text (#1666)

-   Ticket: [ENG-4053]

## Purpose
- Reword finalize registration modal

## Summary of Changes
- Update translation file
  - Reworked modal text so there is no need to change text based on project-based or no-project registration

Author: futa-ikeda

lib/osf-components/addon/components/registries/finalize-registration-modal/component.ts

@@ -3,7 +3,6 @@ import Component from '@ember/component';
 import { assert } from '@ember/debug';
 import { action, computed } from '@ember/object';
 import { inject as service } from '@ember/service';
-import config from 'ember-get-config';
 import Intl from 'ember-intl/services/intl';
 import moment from 'moment';
 
@@ -26,7 +25,6 @@ export default class FinalizeRegisrationModalComponent extends Component {
     makePublicOption = '';
     embargoRangeStartDate: Date = moment().add(3, 'days').toDate();
     embargoRangeEndDate: Date = moment().add(1460, 'days').toDate();
-    learnMoreLink = config.helpLinks.linkToAProject;
 
     didReceiveAttrs() {
         assert('finalize-registration-modal requires @manager!', Boolean(this.manager));
@@ -39,21 +37,13 @@ export default class FinalizeRegisrationModalComponent extends Component {
         }
     }
 
-    @computed('learnMoreLink', 'manager.draftManager.{draftRegistration.hasProject,reviewsWorkflow}')
+    @computed('manager.draftManager.reviewsWorkflow')
     get noticeText() {
-        const translationOptions = { learnMoreLink: this.learnMoreLink, htmlSafe: true };
-        let translationString = '';
-
-        if (this.manager.draftManager.draftRegistration.hasProject) {
-            translationString = this.manager.draftManager.reviewsWorkflow
-                ? 'withModerationFromProject'
-                : 'noModerationFromProject';
-        } else {
-            translationString = this.manager.draftManager.reviewsWorkflow
-                ? 'withModerationNoProject'
-                : 'noModerationNoProject';
-        }
-        return this.intl.t(`registries.finalizeRegistrationModal.notice.${translationString}`, translationOptions);
+        const translationOptions = { htmlSafe: true };
+        const translationString  = this.manager.draftManager.reviewsWorkflow
+            ? 'registries.finalizeRegistrationModal.notice.withModeration'
+            : 'registries.finalizeRegistrationModal.notice.noModeration';
+        return this.intl.t(translationString, translationOptions);
     }
 
     @computed('manager.{hasEmbargoEndDate,submittingRegistration}', 'makePublicOption')

tests/integration/components/registries/finalize-registration-modal/component-test.ts

@@ -110,7 +110,7 @@ module('Integration | Component | finalize-registration-modal', hooks => {
         this.set('isOpen', false);
     });
 
-    test('almost done modal content: no moderation with project', async function(assert) {
+    test('almost done modal content: no moderation', async function(assert) {
         this.store = this.owner.lookup('service:store');
         const noModerationProvider = server.create('registration-provider', { reviewsWorkflow: null });
         const node = server.create('node', 'currentUserAdmin');
@@ -142,17 +142,17 @@ module('Integration | Component | finalize-registration-modal', hooks => {
         // Click submit button
         await click('[data-test-submit-registration-button]');
 
-        const opts = { learnMoreLink: 'aaa.aa', htmlSafe: true };
+        const opts = { htmlSafe: true };
         assert.dom('[data-test-finalize-main]').hasTextContaining(
-            stripHtmlTags(t('registries.finalizeRegistrationModal.notice.noModerationFromProject', opts).toString()),
+            stripHtmlTags(t('registries.finalizeRegistrationModal.notice.noModeration', opts).toString()),
             'modal shows warning',
         );
         assert.dom('[data-test-finalize-main]').doesNotHaveTextContaining(
             'A moderator must review and approve', 'modal does not mention moderation for unmoderated providers',
         );
     });
 
-    test('almost done modal content: with moderation with project', async function(assert) {
+    test('almost done modal content: with moderation', async function(assert) {
         this.store = this.owner.lookup('service:store');
         const withModerationProvider = server.create('registration-provider');
         const node = server.create('node', 'currentUserAdmin');
@@ -188,92 +188,9 @@ module('Integration | Component | finalize-registration-modal', hooks => {
         // Click submit button
         await click('[data-test-submit-registration-button]');
 
-        const opts = { learnMoreLink: 'aaa.aa', htmlSafe: true };
+        const opts = { htmlSafe: true };
         assert.dom('[data-test-finalize-main]').hasTextContaining(
-            stripHtmlTags(t('registries.finalizeRegistrationModal.notice.withModerationFromProject', opts).toString()),
-            'modal shows warning with moderation for moderated providers',
-        );
-    });
-
-    test('almost done modal content: no moderation no project', async function(assert) {
-        this.store = this.owner.lookup('service:store');
-        const noModerationProvider = server.create('registration-provider', { reviewsWorkflow: null });
-        const noModRegistration = server.create(
-            'registration',
-            { provider: noModerationProvider },
-        );
-        const draftRegistration = server.create('draft-registration', { hasProject: false });
-
-        const registrationModel = await this.store.findRecord('registration', noModRegistration.id);
-        this.set('draftManager', {
-            provider: noModerationProvider,
-            draftRegistration,
-            validateAllVisitedPages: () => { /* noop */ },
-        });
-        this.set('model', registrationModel);
-        this.set('isOpen', true);
-        await render(hbs`
-            <Registries::FinalizeRegistrationModal::Manager
-                @registration={{this.model}}
-                @draftManager={{this.draftManager}}
-                as |manager|
-            >
-                <Registries::FinalizeRegistrationModal @isOpen={{this.isOpen}} @manager={{manager}} />
-            </Registries::FinalizeRegistrationModal::Manager>
-        `);
-        // Click immediate radio button
-        await click('[data-test-immediate-button]');
-        // Click submit button
-        await click('[data-test-submit-registration-button]');
-
-        const opts = { learnMoreLink: 'aaa.aa', htmlSafe: true };
-        assert.dom('[data-test-finalize-main]').hasTextContaining(
-            stripHtmlTags(t('registries.finalizeRegistrationModal.notice.noModerationNoProject', opts).toString()),
-            'modal shows warning',
-        );
-        assert.dom('[data-test-finalize-main]').doesNotHaveTextContaining(
-            'A moderator must review and approve', 'modal does not mention moderation for unmoderated providers',
-        );
-    });
-
-    test('almost done modal content: with moderation no project', async function(assert) {
-        this.store = this.owner.lookup('service:store');
-        const withModerationProvider = server.create('registration-provider');
-        const withModRegistration = server.create(
-            'registration',
-            { provider: withModerationProvider },
-        );
-        const draftRegistration = server.create('draft-registration', { hasProject: false });
-
-        const registrationModel = await this.store.findRecord('registration', withModRegistration.id);
-        this.set(
-            'draftManager',
-            {
-                provider: withModerationProvider,
-                reviewsWorkflow: 'pre-moderation',
-                draftRegistration,
-                validateAllVisitedPages: () => { /* noop */ },
-            },
-        );
-        this.set('model', registrationModel);
-        this.set('isOpen', true);
-        await render(hbs`
-            <Registries::FinalizeRegistrationModal::Manager
-                @registration={{this.model}}
-                @draftManager={{this.draftManager}}
-                as |manager|
-            >
-                <Registries::FinalizeRegistrationModal @isOpen={{this.isOpen}} @manager={{manager}} />
-            </Registries::FinalizeRegistrationModal::Manager>
-        `);
-        // Click immediate radio button
-        await click('[data-test-immediate-button]');
-        // Click submit button
-        await click('[data-test-submit-registration-button]');
-
-        const opts = { learnMoreLink: 'aaa.aa', htmlSafe: true };
-        assert.dom('[data-test-finalize-main]').hasTextContaining(
-            stripHtmlTags(t('registries.finalizeRegistrationModal.notice.withModerationNoProject', opts).toString()),
+            stripHtmlTags(t('registries.finalizeRegistrationModal.notice.withModeration', opts).toString()),
             'modal shows warning with moderation for moderated providers',
         );
     });

translations/en-us.yml

@@ -1546,10 +1546,8 @@ registries:
     finalizeRegistrationModal:
         title: 'Almost done...'
         notice:
-            noModerationFromProject: 'Remember:<ul><li>Registrations cannot be modified or deleted once submitted.</li><li>Changes to any files (1) in the projects or components being registered, (2) uploaded or selected as prompt responses, including those connected through add-ons during archiving will result in archiving failure and loss of your registration timestamp. Please do not modify your files until after you have received email confirmation of archiving completion. If this registration has been archiving for more than 72 hours, please email <a href="mailto:support@osf.io">support@osf.io</a> for assistance.</li><li>The content and version history of Wiki and OSF Storage will be copied to the registration.</li><li>This project may contain links to other projects. These links will be copied into your registration, but the projects that they link to will not be registered. If you wish to register the linked projects, they must be registered separately. <a href="{learnMoreLink}" target="_blank" rel="noopener noreferrer">Learn more about links</a>.</li><li>Registrations are archived on Internet Archive and a link to the archived copy will be added to the registration metadata.</li></ul>'
-            withModerationFromProject: 'Remember:<ul><li>Registrations cannot be modified or deleted once submitted.</li><li>Changes to any files (1) in the projects or components being registered, (2) uploaded or selected as prompt responses, including those connected through add-ons during archiving will result in archiving failure and loss of your registration timestamp. Please do not modify your files until after you have received email confirmation of archiving completion. If this registration has been archiving for more than 72 hours, please email <a href="mailto:support@osf.io">support@osf.io</a> for assistance.</li><li>The content and version history of Wiki and OSF Storage will be copied to the registration.</li><li>This project may contain links to other projects. These links will be copied into your registration, but the projects that they link to will not be registered. If you wish to register the linked projects, they must be registered separately. <a href="{learnMoreLink}" target="_blank" rel="noopener noreferrer">Learn more about links</a>.</li><li>A moderator must review and approve your registration before it will be made public or embargoed.</li><li>Registrations are archived on Internet Archive and a link to the archived copy will be added to the registration metadata.</li></ul>'
-            noModerationNoProject: 'Remember:<ul><li>Registrations cannot be modified or deleted once submitted.</li><li>Changes to any files uploaded or selected as prompt responses will result in archiving failure and loss of your registration timestamp. If this registration has been archiving for more than 72 hours, email <a href="mailto:support@osf.io">support@osf.io</a> for assistance.</li><li>Registrations are archived on Internet Archive and a link to the archived copy will be added to the registration metadata.</li></ul>'
-            withModerationNoProject: 'Remember:<ul><li>Registrations cannot be modified or deleted once submitted.</li><li>Changes to any files uploaded or selected as prompt responses will result in archiving failure and loss of your registration timestamp. If this registration has been archiving for more than 72 hours, email <a href="mailto:support@osf.io">support@osf.io</a> for assistance.</li><li>A moderator must review and approve your registration before it will be made public or embargoed.</li><li>Registrations are archived on Internet Archive and a link to the archived copy will be added to the registration metadata.</li></ul>'
+            noModeration: 'Remember:<ul><li>Do not edit any files until the registration has completely archived.</li><li>This will be permanent and cannot be deleted once submitted.</li><li>This registration will be copied to Internet Archive as a backup.</li><li>Title and contributors cannot be updated once submitted.</li></ul>'
+            withModeration: 'Remember:<ul><li>Do not edit any files until the registration has completely archived.</li><li>This will be permanent and cannot be deleted once submitted.</li><li>This registration will be copied to Internet Archive as a backup.</li><li>Title and contributors cannot be updated once submitted.</li><li>A moderator will review your registration before it will made public or embargoed.</li></ul>'
         immediateOption: 'Make registration public immediately'
         embargoOption: 'Enter registration into embargo'