Fix node-card date for older registrations (#1373)

-   Ticket: [ENG-700]
-   Feature flag: n/a

## Purpose
- Currently the node-card component (used on a project's registration page and the my-registrations page) is saying that a Registration was registered when the backing project was created. For older (not exactly sure how old), project-based registrations, this will not be true and will lead to user confusion.

## Summary of Changes
- Change the date we are showing from the registration.dateCreated (date created of backing project), to registration.dateRegistered (when the registration was actually registered)
- Update tests

Author: futa-ikeda

lib/osf-components/addon/components/node-card/template.hbs

@@ -123,15 +123,22 @@
                     <dd data-test-registration-registry-name>
                         {{@node.provider.name}}
                     </dd><br />
+                    <dt data-test-created-timestamp-label>
+                        {{t (concat 'node_card.registration.timestamp_label')}}
+                    </dt>
+                    <dd data-test-created-timestamp-value>
+                        {{moment @node.dateRegistered}}
+                    </dd><br />
+                {{else}}
+                    <dt data-test-created-timestamp-label>
+                        {{t (concat 'node_card.' @node.nodeType '.timestamp_label')}}
+                    </dt>
+                    <dd data-test-created-timestamp-value>
+                        {{moment @node.dateCreated}}
+                    </dd><br />
                 {{/if}}
-                <dt data-test-created-timestamp-label>
-                    {{t (concat 'node_card.' @node.nodeType '.timestamp_label')}}        
-                </dt>
-                <dd data-test-created-timestamp-value>
-                    {{moment @node.dateCreated}}
-                </dd><br />
                 <dt data-test-updated-timestamp-label>
-                    {{t 'node_card.last_updated'}}        
+                    {{t 'node_card.last_updated'}}
                 </dt>
                 <dd data-test-updated-timestamp-value>
                     {{moment @node.dateModified}}

tests/integration/components/node-card/component-test.ts

@@ -68,7 +68,7 @@ module('Integration | Component | node-card', hooks => {
         );
         assert.dom('[data-test-created-timestamp-value]').exists('Created timestamp value exists');
         assert.dom('[data-test-created-timestamp-value]').hasText(
-            `${moment(registration.dateCreated)}`,
+            `${moment(registration.dateRegistered)}`,
             'Created timestamp value is correct',
         );
         assert.dom('[data-test-updated-timestamp-value]').exists('Updated timestamp value exists');