Additional tweaks for Revision workflow (#1360)

* Wording changes for revision submission toast

* Replace bad fix for accessibility color changes

* Update test

Author: futa-ikeda

app/styles/_variables.scss

@@ -31,7 +31,7 @@ $brand-warning: #f0ad4e !default;
 $brand-danger: #d9534f;
 
 /* overrides with darkened colors for a11y contrast */
-$brand-success: darken($brand-success, 20%);
+$brand-success: darken($brand-success, 10%);
 $brand-info: darken($brand-info, 15%);
 // no override needed for brand-warning (will use dark text instead)
 $brand-danger: darken($brand-danger, 15%);

lib/osf-components/addon/components/button/styles.scss

@@ -59,11 +59,11 @@
 }
 
 .CreateButton {
-    background-color: $brand-success;
+    background-color: darken($brand-success, 10%);
     color: $color-text-white;
 
     &:hover:not([disabled]) {
-        background-color: darken($brand-success, 15%);
+        background-color: darken($brand-success, 25%);
     }
 }
 

lib/registries/addon/edit-revision/-components/submit-and-decide/component.ts

@@ -58,7 +58,11 @@ export default class SubmitAndDecide extends Component {
             });
             await schemaResponseAction.save();
             await this.revisionManager.revision.reload();
-            this.toast.success(this.intl.t('registries.edit_revision.review.action_submit_success'));
+            let successMessage = this.intl.t('registries.edit_revision.review.action_submit_success');
+            if (actionTrigger === SchemaResponseActionTrigger.SubmitRevision) {
+                successMessage = this.intl.t('registries.edit_revision.review.submit_success');
+            }
+            this.toast.success(successMessage);
         } catch (e) {
             const errorMessage = this.intl.t('registries.edit_revision.review.action_submit_failed');
             captureException(e, { errorMessage });

tests/engines/registries/acceptance/edit-revision/revision-test.ts

@@ -499,7 +499,7 @@ module('Registries | Acceptance | registries revision', hooks => {
         await visit(`/registries/revisions/${revision.id}/review`);
         await click('[data-test-submit-revision]');
         assert.dom('#toast-container', document as any).hasTextContaining(t(
-            'registries.edit_revision.review.action_submit_success',
+            'registries.edit_revision.review.submit_success',
         ), 'Toast message shown after initial submit');
         assert.dom('[data-test-submit-revision]').doesNotExist('Submit button no longer shown');
         assert.dom('[data-test-goto-previous-page]').doesNotExist('There is no turning back from this');

translations/en-us.yml

@@ -1211,6 +1211,7 @@ registries:
             decision_recorded_notice: 'Decision recorded. Pending decisions from other Admin contributors.'
             pending_admin_notice: 'Pending decisions from admin(s).'
             pending_moderation_notice: 'Pending decisions from moderators.'
+            submit_success: 'Submitted for Admin approval'
             action_submit_success: 'Your decision was recorded'
             action_submit_failed: 'Your decision was not recorded'
             non_admin_warning: 'Only admins can submit an update.'