fix: search-result context text (#2545)

Author: aaxelb

app/models/search-result.ts

@@ -7,18 +7,16 @@ import { languageFromLanguageCode } from 'osf-components/components/file-metadat
 
 import IndexCardModel from './index-card';
 
-const textMatchEvidenceType = 'https://share.osf.io/vocab/2023/trove/TextMatchEvidence';
-
 export interface IriMatchEvidence {
-    '@type': [string];
     matchingIri: string;
     osfmapPropertyPath: string[];
+    propertyPathKey: string;
 }
 
 export interface TextMatchEvidence {
-    '@type': [string];
     matchingHighlight: string;
     osfmapPropertyPath: string[];
+    propertyPathKey: string;
 }
 
 export const CardLabelTranslationKeys = {
@@ -50,9 +48,11 @@ export default class SearchResultModel extends Model {
         if (this.matchEvidence) {
             const matchEvidenceString = this.matchEvidence.reduce(
                 (acc, current) => acc.concat(
-                    `${current.osfmapPropertyPath[0]}: ${current['@type'][0] === textMatchEvidenceType
-                        ? (current as TextMatchEvidence).matchingHighlight
-                        : (current as IriMatchEvidence).matchingIri}; `,
+                    `${current.propertyPathKey}: ${
+                        ('matchingHighlight' in current)
+                            ? current.matchingHighlight
+                            : current.matchingIri
+                    }`,
                 ),
                 '',
             );

mirage/views/search.ts

@@ -339,8 +339,9 @@ export function cardSearch(_: Schema, request: Request) {
                     propertyPathKey: 'rights',
                     matchEvidence: [
                         {
-                            '@type': ['https://share.osf.io/vocab/2023/trove/IriMatchEvidence'],
-                            osfmapPropertyPath: 'resourceType',
+                            '@type': ['trove:IriMatchEvidence'],
+                            osfmapPropertyPath: ['resourceType'],
+                            propertyPathKey: 'resourceType',
                             matchingIri: 'rdf:Property',
                         },
                     ],
@@ -377,8 +378,9 @@ export function cardSearch(_: Schema, request: Request) {
                     propertyPathKey: 'datePublished',
                     matchEvidence: [
                         {
-                            '@type': ['https://share.osf.io/vocab/2023/trove/IriMatchEvidence'],
-                            osfmapPropertyPath: 'resourceType',
+                            '@type': ['trove:IriMatchEvidence'],
+                            osfmapPropertyPath: ['resourceType'],
+                            propertyPathKey: 'resourceType',
                             matchingIri: 'rdf:Property',
                         },
                     ],
@@ -415,8 +417,9 @@ export function cardSearch(_: Schema, request: Request) {
                     propertyPathKey: 'funder',
                     matchEvidence: [
                         {
-                            '@type': ['https://share.osf.io/vocab/2023/trove/IriMatchEvidence'],
-                            osfmapPropertyPath: 'resourceType',
+                            '@type': ['trove:IriMatchEvidence'],
+                            osfmapPropertyPath: ['resourceType'],
+                            propertyPathKey: 'resourceType',
                             matchingIri: 'rdf:Property',
                         },
                     ],
@@ -466,7 +469,7 @@ export function cardSearch(_: Schema, request: Request) {
             attributes: {
                 matchEvidence: [
                     {
-                        '@type': ['https://share.osf.io/vocab/2023/trove/TextMatchEvidence'],
+                        '@type': ['trove:TextMatchEvidence'],
                         evidenceCardIdentifier: indexCardURL,
                         matchingHighlight: [`...<em>${faker.lorem.word()}</em>...`],
                         osfmapPropertyPath: ['description'],
@@ -576,8 +579,9 @@ export function valueSearch(_: Schema, __: Request) {
                 attributes: {
                     matchEvidence: [
                         {
-                            '@type': ['https://share.osf.io/vocab/2023/trove/TextMatchEvidence'],
-                            osfmapPropertyPath: 'title',
+                            '@type': ['trove:TextMatchEvidence'],
+                            osfmapPropertyPath: ['title'],
+                            propertyPathKey: 'title',
                             matchingHighlight: 'National <em>Institute of Health</em>',
                         },
                     ],
@@ -596,8 +600,9 @@ export function valueSearch(_: Schema, __: Request) {
                 attributes: {
                     matchEvidence: [
                         {
-                            '@type': ['https://share.osf.io/vocab/2023/trove/TextMatchEvidence'],
-                            osfmapPropertyPath: 'title',
+                            '@type': ['trove:TextMatchEvidence'],
+                            osfmapPropertyPath: ['title'],
+                            propertyPathKey: 'title',
                             matchingHighlight: 'Virginia <em>Institute of Health</em>',
                         },
                     ],