Fixed the strings for selecting a file from a project

Author: bp-cos

app/preprints/-components/submit/file/component.ts

@@ -50,6 +50,10 @@ export default class PreprintFile extends Component<FileArgs>{
         }
     }
 
+    public get isSelectProjectButtonDisplayed(): boolean {
+        return !this.args.manager.isEditFlow;
+    }
+
     public get isSelectProjectButtonDisabled(): boolean {
         return this.isButtonDisabled || this.isEdit;
     }
@@ -111,9 +115,13 @@ export default class PreprintFile extends Component<FileArgs>{
         this.validate(file);
     }
 
+    public get getSelectExplanationText(): string {
+        return this.intl.t('preprints.submit.step-file.project-select-explanation',
+            { singularPreprintWord: this.args.manager.provider.documentType.singularCapitalized });
+    }
+
     public get getUploadText(): string {
         return this.intl.t('preprints.submit.step-file.upload-title',
             { singularPreprintWord: this.args.manager.provider.documentType.singularCapitalized });
-
     }
 }

app/preprints/-components/submit/file/template.hbs

@@ -4,6 +4,11 @@
     >
         {{t 'preprints.submit.step-file.title'}}
     </h3>
+    {{#if this.isSelectProjectButtonDisplayed}}
+        <p>
+            {{t 'preprints.submit.step-file.upload-warning'}}
+        </p>
+    {{/if}}
     {{#if this.loadFiles.isRunning}}
         <LoadingIndicator data-test-loading-indicator @dark={{true}} />
     {{else}} 
@@ -34,20 +39,22 @@
                     >
                         {{ t 'preprints.submit.step-file.file-upload-label'}}
                     </Button>
-                    <Button
-                        data-test-select-button
-                        data-analytics-name='Select button'
-                        {{on 'click' this.displayFileSelect}}
-                        local-class='btn'
-                        disabled={{this.isSelectProjectButtonDisabled}}
-                    >
-                        {{ t 'preprints.submit.step-file.file-select-label'}}
-                        {{#if this.isSelectProjectButtonDisabled}}
-                            <EmberTooltip>
-                                {{t 'preprints.submit.step-file.project-select-explanation'}}
-                            </EmberTooltip>
-                        {{/if}}
-                    </Button>
+                    {{#if this.isSelectProjectButtonDisplayed}}
+                        <Button
+                            data-test-select-button
+                            data-analytics-name='Select button'
+                            {{on 'click' this.displayFileSelect}}
+                            local-class='btn'
+                            disabled={{this.isSelectProjectButtonDisabled}}
+                        >
+                            {{ t 'preprints.submit.step-file.file-select-label'}}
+                            {{#if this.isEdit}}
+                                <EmberTooltip>
+                                    {{this.getSelectExplanationText}}
+                                </EmberTooltip>
+                            {{/if}}
+                        </Button>
+                    {{/if}}
                 </div>
                 {{#if this.isFileUploadDisplayed}}
                     {{#let (unique-id 'preprint-upload-files-dropzone') as |id|}}

translations/en-us.yml

@@ -1191,14 +1191,15 @@ preprints:
             delete-modal-button-tooltip: 'Version file'
             delete-modal-title: 'Add a new {singularPreprintWord} file'
             delete-warning: 'This will allow a new version of the {singularPreprintWord} file to be uploaded to the {singularPreprintWord}. The existing file will be retained as a version of the {singularPreprintWord}.'
-            uploaded-file-title: 'Attached {singularPreprintWord} file'
             file-select-label: 'Select from an existing OSF project'
             file-upload-label: 'Upload from your computer'
             file-upload-label-one: 'Drag and drop files here to upload'
             file-upload-label-two: 'or click to browse for files.'
-            project-select-explanation: 'A file from a project can only be selected once.'
+            project-select-explanation: 'A file is attach to this {singularPreprintWord} draft. You can upload a new file version using the “Upload from your computer” option. Start a new {singularPreprintWord} if you need to attach a file from a project.'
             title: 'File'
+            uploaded-file-title: 'Attached {singularPreprintWord} file'
             upload-title: 'Upload your {singularPreprintWord}'
+            upload-warning: 'You cannot switch options once a file is attached.'
         step-metadata:
             title: 'Metadata'
             contributors-input: 'Contributors'