Fix icons for registries leftnav show/hide in mobile view (#1659)

brianjgeiger · web-flow · commit 78b2f22dfcd3 · 2022-09-14T15:04:37.000-04:00
-   Ticket: [ENG-4014]

## Purpose

The fontawesome upgrade requires no positional arguments for FaIcon. I thought I had caught all of them, but at least one set got past me.

## Summary of Changes

1. Fix icons for registries leftnav show/hide in mobile view
diff --git a/lib/registries/addon/overview/-components/overview-header/template.hbs b/lib/registries/addon/overview/-components/overview-header/template.hbs
@@ -19,7 +19,7 @@
                             aria-label={{t 'registries.overview.toggle_navbar'}}
                             data-analytics-name='Show sidenav'
                         >
-                            {{nav.icon (if @sidenavGutterClosed 'bars' 'times')}}
+                            <nav.icon @icon={{if @sidenavGutterClosed 'bars' 'times'}} />
                         </nav.buttons.default>
                     </nav.bordered-section>
 

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`aria-label={{t 'registries.overview.toggle_navbar'}}`
`20`	`20`	`data-analytics-name='Show sidenav'`
`21`	`21`	`>`
`22`		`- {{nav.icon (if @sidenavGutterClosed 'bars' 'times')}}`
	`22`	`+ <nav.icon @icon={{if @sidenavGutterClosed 'bars' 'times'}} />`
`23`	`23`	`</nav.buttons.default>`
`24`	`24`	`</nav.bordered-section>`
`25`	`25`