Skip to content

Commit 7786c92

Browse files
authored
[ENG-3237][ENG-3238] Fix accessibility problems on collections submission page (#1315)
- Tickets: [ENG-3237](https://openscience.atlassian.net/browse/ENG-3237) [ENG-3238](https://openscience.atlassian.net/browse/ENG-3238) - Feature flag: n/a ## Purpose Fix the accessibility problems on the Collections submission page ## Summary of Changes 1. Darken header text for each input section 2. Add aria label to search text input 3. Add aria label to search action button 4. Remove hidden label from bibliographic checkboxes 5. Add aria label to bibliographic checkboxes ## Side Effects No, these should be isolated ## QA Notes Functionality shouldn't be affected, only accessibility.
1 parent 3d322b6 commit 7786c92

File tree

5 files changed

+10
-13
lines changed

5 files changed

+10
-13
lines changed

lib/app-components/addon/components/project-contributors/list/item/styles.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@
3737
height: 30px;
3838
}
3939

40-
.checkbox-label {
41-
font-weight: normal;
42-
padding-right: 5px;
43-
}
44-
4540
@media (min-width: 768px) {
4641
.text-sm-center {
4742
text-align: center;

lib/app-components/addon/components/project-contributors/list/item/template.hbs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,12 @@
5858
{{! Bibliographic (Citation) }}
5959
<div data-test-project-contributors-list-item-citation-checkbox local-class='text-sm-center'
6060
class='col-xs-10 col-sm-2 col-sm-offset-0 bib-padding'>
61-
<label local-class='checkbox-label' class='visible-xs-inline' for='{{@contributor.id}}-citation'>
62-
<em>
63-
{{t 'app_components.project_contributors.list.item.in_citation_label'}}
64-
</em>
65-
</label>
66-
<Input @id={{concat @contributor.id '-citation'}} @type='checkbox' @disabled={{not this.canChangeBibliographic}}
67-
@checked={{@contributor.bibliographic}} @change={{action @toggleBibliographic @contributor}} />
61+
<Input
62+
aria-label={{t 'app_components.project_contributors.list.item.in_citation_label'}}
63+
@type='checkbox'
64+
@disabled={{not this.canChangeBibliographic}}
65+
@checked={{@contributor.bibliographic}}
66+
@change={{action @toggleBibliographic @contributor}} />
6867
</div>
6968

7069
{{! Remove }}

lib/app-components/addon/components/project-contributors/search/template.hbs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,15 @@
55
class='input-group'
66
>
77
<Input
8+
aria-label={{t 'app_components.project_contributors.search.placeholder'}}
89
@class='form-control'
910
@value={{this.query}}
1011
@placeholder={{t 'app_components.project_contributors.search.placeholder'}}
1112
/>
1213
<span class='input-group-btn'>
1314
<button
1415
data-test-project-contributors-search-button
16+
aria-label={{t 'app_components.project_contributors.search.perform_search'}}
1517
local-class='authors-search-button'
1618
class='btn btn-default'
1719
type='submit'

lib/app-components/addon/components/submit-section/active/styles.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.closed {
2-
color: #888;
2+
color: $color-text-black;
33
}
44

55
.green {

translations/en-us.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -777,6 +777,7 @@ app_components:
777777
add: Add
778778
add_contributor_success: 'Project contributor added!'
779779
add_contributor_error: 'Could not add contributor.'
780+
perform_search: 'Perform search'
780781
project_metadata:
781782
field_title_label: 'Title:'
782783
field_title_placeholder: ""

0 commit comments

Comments
 (0)