Skip to content

Commit 3a2d898

Browse files
authored
fix URL query param issue (#2237)
- Ticket: https://openscience.atlassian.net/browse/ENG-5228 - Feature flag: n/a ## Purpose Fix search text not populating as query parameter and correct filter-value preview counts. ## Summary of Changes - Renamed cardSearchText to q and @query to @cardSearchText in the search page controller and templates. - Adjusted filter-value preview counts to reflect the current search context's result count.
1 parent 8b15dbb commit 3a2d898

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

app/search/controller.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
} from 'osf-components/components/search-page/component';
77

88
export default class SearchController extends Controller {
9-
@tracked cardSearchText?: string = '';
9+
@tracked q?: string = '';
1010
@tracked sort?: string = '-relevance';
1111
@tracked resourceType?: ResourceTypeFilterValue | null = null;
1212
@tracked activeFilters?: Filter[] = [];

lib/registries/addon/branded/discover/template.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
@defaultQueryOptions={{this.defaultQueryOptions}}
1010
@resourceType={{'Registration,RegistrationComponent'}}
1111
@queryParams={{this.queryParams}}
12-
@query={{this.q}}
12+
@cardsearchText={{this.q}}
1313
@sort={{this.sort}}
1414
@onQueryParamChange={{action this.onQueryParamChange}}
1515
@showResourceTypeFilter={{false}}

mirage/views/search.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,7 @@ export function valueSearch(_: Schema, __: Request) {
469469
matchingHighlight: 'National <em>Institute of Health</em>',
470470
},
471471
],
472-
cardSearchResultCount: 2134,
472+
cardSearchResultCount: 3,
473473
},
474474
relationships: {
475475
indexCard: {

0 commit comments

Comments
 (0)