[ENG-3486] Fix language for overview revision metadata (#1372)

* Fix language for overview revision metadata + tests

* Fix tests

Author: futa-ikeda

lib/osf-components/addon/components/registries/overview-form-renderer/template.hbs

@@ -2,7 +2,10 @@
     <LoadingIndicator @dark={{true}}/>
 {{else}}
     {{#if this.showMetadata}}
-        <Registries::VersionMetadata @revision={{@revision}} />
+        <Registries::VersionMetadata
+            @revision={{@revision}}
+            @registration={{@registration}}
+        />
     {{/if}}
     <Registries::RegistrationFormNavigationDropdown
         @showMetadata={{false}}

lib/osf-components/addon/components/registries/version-metadata/template.hbs

@@ -1,4 +1,5 @@
 {{assert 'Registries::VersionMetadata requires @revision' @revision}}
+{{assert 'Registries::VersionMetadata requires @registration' @registration}}
 <section
     local-class='versionMetadata'
 > 
@@ -14,7 +15,7 @@
     {{!-- TODO: add description for what fields have changed --}}
     <p data-test-version-metadata-date>
         {{if @revision.isOriginalResponse 
-            (t 'registries.overview.versionMetadata.originalDate' date=(moment-format @revision.dateModified 'MMM DD, YYYY'))
+            (t 'registries.overview.versionMetadata.originalDate' date=(moment-format @registration.dateRegistered 'MMM DD, YYYY'))
             (t 'registries.overview.versionMetadata.date' date=(moment-format @revision.dateModified 'MMM DD, YYYY'))
         }}
     </p>

mirage/factories/registration.ts

@@ -151,6 +151,7 @@ export default NodeFactory.extend<MirageRegistration & RegistrationTraits>({
             registrationSchema: newReg.registrationSchema,
             reviewsState: RevisionReviewStates.Unapproved,
             revisionResponses: newReg.registrationResponses,
+            isOriginalResponse: true,
         });
         newReg.update({ originalResponse: baseResponse });
         newReg.update({ latestResponse: baseResponse });

tests/engines/registries/acceptance/overview/revision-test.ts

@@ -37,6 +37,7 @@ module('Registries | Acceptance | overview.revision', hooks => {
             revisionResponses: { q1: 'Super Man' },
             registration,
         });
+        registration.update({ latestResponse: revision });
         await visit(`/${registration.id}?revisionId=${revision.id}`);
         assert.dom('[data-test-version-metadata-title]')
             .exists('version metadata is shown when viewing a specific revision');

tests/integration/components/registries/update-dropdown/component-test.ts

@@ -52,7 +52,7 @@ module('Integration | Component  | update-dropdown', hooks => {
         `);
         assert.dom('[data-test-update-button]').containsText(t('registries.update_dropdown.latest'), 'Latest selected');
         await click('[data-test-update-button]');
-        assert.dom('[data-test-revision-link]').exists({ count: 3 }, '3 revisions shown');
+        assert.dom('[data-test-revision-link]').exists({ count: 4 }, '4 revisions shown');
 
         assert.dom('[data-test-update-dropdown-show-more]').doesNotExist('Show more element not shown');
         assert.dom('[data-test-update-dropdown-create-new-revision]').doesNotExist('New update button not shown');
@@ -86,7 +86,7 @@ module('Integration | Component  | update-dropdown', hooks => {
             .doesNotExist('Link to revision in progress not shown');
     });
 
-    test('update dropdown - 3 revisions, one in progress', async function(this: ComponentTestContext, assert) {
+    test('update dropdown - 3 extra revisions, one in progress', async function(this: ComponentTestContext, assert) {
         const mirageRegistration = server.create('registration', {
             id: 'cobalt',
             title: 'Outcome Reporting Testing',
@@ -114,7 +114,7 @@ module('Integration | Component  | update-dropdown', hooks => {
             <Registries::UpdateDropdown @registration={{this.registration}}/>
         `);
         await click('[data-test-update-button]');
-        assert.dom('[data-test-revision-link]').exists({ count: 2 }, 'revision in progress not listed');
+        assert.dom('[data-test-revision-link]').exists({ count: 3 }, 'revision in progress not listed');
 
         assert.dom('[data-test-update-dropdown-show-more]').doesNotExist('Show more element not shown');
         assert.dom('[data-test-update-dropdown-create-new-revision]').doesNotExist('New update button not shown');

tests/integration/components/registries/version-metadata/component-test.ts

@@ -13,27 +13,47 @@ module('Integration | Component | version-metadata', hooks => {
     setupMirage(hooks);
     setupIntl(hooks);
 
-    // TODO: Test registrations with 2 revisions, registration with 2 revisions with one selected
-    test('it renders', async function(this: TestContext, assert) {
-        const currentUser = server.create('user', { fullName: 'Lex Luthor' }, 'loggedIn');
+    test('it renders original', async function(this: TestContext, assert) {
+        const registration = server.create('registration');
+        this.set('registration', registration);
+        this.set('revision', registration.originalResponse);
+        await render(hbs`
+        <Registries::VersionMetadata
+            @registration={{this.registration}} @revision={{this.revision}}
+        />`);
+        assert.dom('[data-test-version-metadata-title]').hasText(
+            t('registries.overview.versionMetadata.originalTitle'), 'title indicates original version',
+        );
+        assert.dom('[data-test-version-metadata-date]').hasTextContaining(
+            t('registries.overview.versionMetadata.originalDate', {
+                date: moment(registration.dateRegistered).format('MMM DD, YYYY'),
+            }), 'Registration submission date is shown',
+        );
+        assert.dom('[data-test-version-metadata-reason]')
+            .doesNotExist();
+    });
+
+    test('it renders subsequent revision', async function(this: TestContext, assert) {
+        const registration = server.create('registration');
+        const justification = 'this is why';
         const revision = server.create('schema-response', {
-            isOriginalResponse: true,
-            initiatedBy: currentUser,
-            dateModified: new Date(),
-            revisionJustification: 'This registration went into a phone booth',
-            revisionResponses: { q1: 'Super Man' },
+            registration,
+            revisionJustification: justification,
         });
+        this.set('registration', registration);
         this.set('revision', revision);
-        await render(hbs`<Registries::VersionMetadata @revision={{this.revision}} />`);
+        await render(hbs`
+        <Registries::VersionMetadata
+            @registration={{this.registration}} @revision={{this.revision}}
+        />`);
         assert.dom('[data-test-version-metadata-title]').hasText(
-            t('registries.overview.versionMetadata.originalTitle'), 'revision title is shown',
+            t('registries.overview.versionMetadata.updateTitle'), 'title indicates updated version',
         );
         assert.dom('[data-test-version-metadata-date]').hasTextContaining(
-            t('registries.overview.versionMetadata.originalDate', {
+            t('registries.overview.versionMetadata.date', {
                 date: moment(revision.dateModified).format('MMM DD, YYYY'),
-            }), 'revision initiator is shown',
+            }), 'revision modification date is shown',
         );
-        assert.dom('[data-test-version-metadata-reason]')
-            .doesNotExist();
+        assert.dom('[data-test-version-metadata-reason]').hasTextContaining(justification);
     });
 });