Skip to content

Commit dbf0b72

Browse files
authored
[ENG-9768] Submitting new versions to OSF Preprints no longer publishes new version (#795)
- Ticket: [ENG-9768] - Feature flag: n/a
1 parent 086188b commit dbf0b72

File tree

41 files changed

+182
-187
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

41 files changed

+182
-187
lines changed

src/app/app.routes.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,10 @@ export const routes: Routes = [
7474
{
7575
path: 'my-registrations',
7676
canActivate: [authGuard],
77-
loadComponent: () => import('@osf/features/registries/pages').then((c) => c.MyRegistrationsComponent),
77+
loadComponent: () =>
78+
import('@osf/features/registries/pages/my-registrations/my-registrations.component').then(
79+
(c) => c.MyRegistrationsComponent
80+
),
7881
providers: [
7982
provideStates([RegistriesState]),
8083
ProvidersHandlers,

src/app/features/files/components/confirm-move-file-dialog/confirm-move-file-dialog.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { FileMenuType } from '@shared/enums/file-menu-type.enum';
1919
import { FileModel } from '@shared/models/files/file.model';
2020

2121
@Component({
22-
selector: 'osf-move-file-dialog',
22+
selector: 'osf-confirm-move-file-dialog',
2323
imports: [Button, TranslatePipe],
2424
templateUrl: './confirm-move-file-dialog.component.html',
2525
styleUrl: './confirm-move-file-dialog.component.scss',

src/app/features/files/components/move-file-dialog/move-file-dialog.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
1717
import {
1818
FilesSelectors,
1919
GetMoveDialogFiles,
20-
SetCurrentFolder,
20+
SetFilesCurrentFolder,
2121
SetMoveDialogCurrentFolder,
2222
} from '@osf/features/files/store';
2323
import { FileSelectDestinationComponent } from '@osf/shared/components/file-select-destination/file-select-destination.component';
@@ -80,7 +80,7 @@ export class MoveFileDialogComponent {
8080
readonly actions = createDispatchMap({
8181
getMoveDialogFiles: GetMoveDialogFiles,
8282
setMoveDialogCurrentFolder: SetMoveDialogCurrentFolder,
83-
setCurrentFolder: SetCurrentFolder,
83+
setCurrentFolder: SetFilesCurrentFolder,
8484
getResourceDetails: GetResourceDetails,
8585
getComponentsTree: GetResourceWithChildren,
8686
});

src/app/features/files/pages/files/files.component.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,9 +46,9 @@ import {
4646
GetRootFolders,
4747
GetStorageSupportedFeatures,
4848
RenameEntry,
49-
ResetState,
50-
SetCurrentFolder,
49+
ResetFilesState,
5150
SetCurrentProvider,
51+
SetFilesCurrentFolder,
5252
SetMoveDialogCurrentFolder,
5353
SetSearch,
5454
SetSort,
@@ -138,14 +138,14 @@ export class FilesComponent {
138138
getFiles: GetFiles,
139139
deleteEntry: DeleteEntry,
140140
renameEntry: RenameEntry,
141-
setCurrentFolder: SetCurrentFolder,
141+
setCurrentFolder: SetFilesCurrentFolder,
142142
setMoveDialogCurrentFolder: SetMoveDialogCurrentFolder,
143143
setSearch: SetSearch,
144144
setSort: SetSort,
145145
getRootFolders: GetRootFolders,
146146
getConfiguredStorageAddons: GetConfiguredStorageAddons,
147147
setCurrentProvider: SetCurrentProvider,
148-
resetState: ResetState,
148+
resetState: ResetFilesState,
149149
getResourceDetails: GetResourceDetails,
150150
getStorageSupportedFeatures: GetStorageSupportedFeatures,
151151
});

src/app/features/files/store/files.actions.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ export class SetSort {
3232
constructor(public sort: string) {}
3333
}
3434

35-
export class SetCurrentFolder {
36-
static readonly type = '[Files] Set Current Folder';
35+
export class SetFilesCurrentFolder {
36+
static readonly type = '[Files] Set Files Current Folder';
3737

3838
constructor(public folder: FileFolderModel | null) {}
3939
}
@@ -161,6 +161,6 @@ export class GetStorageSupportedFeatures {
161161
) {}
162162
}
163163

164-
export class ResetState {
164+
export class ResetFilesState {
165165
static readonly type = '[Files] Reset State';
166166
}

src/app/features/files/store/files.state.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,10 @@ import {
2727
GetRootFolders,
2828
GetStorageSupportedFeatures,
2929
RenameEntry,
30-
ResetState,
31-
SetCurrentFolder,
30+
ResetFilesState,
3231
SetCurrentProvider,
3332
SetFileMetadata,
33+
SetFilesCurrentFolder,
3434
SetMoveDialogCurrentFolder,
3535
SetSearch,
3636
SetSort,
@@ -94,8 +94,8 @@ export class FilesState {
9494
);
9595
}
9696

97-
@Action(SetCurrentFolder)
98-
setSelectedFolder(ctx: StateContext<FilesStateModel>, action: SetCurrentFolder) {
97+
@Action(SetFilesCurrentFolder)
98+
setSelectedFolder(ctx: StateContext<FilesStateModel>, action: SetFilesCurrentFolder) {
9999
ctx.patchState({ currentFolder: action.folder });
100100
}
101101

@@ -360,7 +360,7 @@ export class FilesState {
360360
);
361361
}
362362

363-
@Action(ResetState)
363+
@Action(ResetFilesState)
364364
resetState(ctx: StateContext<FilesStateModel>) {
365365
ctx.patchState(FILES_STATE_DEFAULTS);
366366
}

src/app/features/preprints/components/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ export { PreprintMakeDecisionComponent } from './preprint-details/preprint-make-
88
export { PreprintMetricsInfoComponent } from './preprint-details/preprint-metrics-info/preprint-metrics-info.component';
99
export { PreprintTombstoneComponent } from './preprint-details/preprint-tombstone/preprint-tombstone.component';
1010
export { PreprintWarningBannerComponent } from './preprint-details/preprint-warning-banner/preprint-warning-banner.component';
11+
export { PreprintWithdrawDialogComponent } from './preprint-details/preprint-withdraw-dialog/preprint-withdraw-dialog.component';
1112
export { ShareAndDownloadComponent } from './preprint-details/share-and-download/share-and-download.component';
1213
export { StatusBannerComponent } from './preprint-details/status-banner/status-banner.component';
13-
export { WithdrawDialogComponent } from './preprint-details/withdraw-dialog/withdraw-dialog.component';
1414
export { PreprintProviderFooterComponent } from './preprint-provider-footer/preprint-provider-footer.component';
1515
export { PreprintProviderHeroComponent } from './preprint-provider-hero/preprint-provider-hero.component';
1616
export { PreprintServicesComponent } from './preprint-services/preprint-services.component';

src/app/features/preprints/components/preprint-details/general-information/general-information.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import { FormsModule } from '@angular/forms';
1111
import { ENVIRONMENT } from '@core/provider/environment.provider';
1212
import { ApplicabilityStatus, PreregLinkInfo } from '@osf/features/preprints/enums';
1313
import { PreprintProviderDetails } from '@osf/features/preprints/models';
14-
import { FetchPreprintById, PreprintSelectors } from '@osf/features/preprints/store/preprint';
14+
import { FetchPreprintDetails, PreprintSelectors } from '@osf/features/preprints/store/preprint';
1515
import { AffiliatedInstitutionsViewComponent } from '@osf/shared/components/affiliated-institutions-view/affiliated-institutions-view.component';
1616
import { ContributorsListComponent } from '@osf/shared/components/contributors-list/contributors-list.component';
1717
import { IconComponent } from '@osf/shared/components/icon/icon.component';
@@ -55,7 +55,7 @@ export class GeneralInformationComponent implements OnDestroy {
5555
private actions = createDispatchMap({
5656
getBibliographicContributors: GetBibliographicContributors,
5757
resetContributorsState: ResetContributorsState,
58-
fetchPreprintById: FetchPreprintById,
58+
fetchPreprintById: FetchPreprintDetails,
5959
fetchResourceInstitutions: FetchResourceInstitutions,
6060
loadMoreBibliographicContributors: LoadMoreBibliographicContributors,
6161
});

src/app/features/preprints/components/preprint-details/preprint-tombstone/preprint-tombstone.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { Router } from '@angular/router';
1212

1313
import { ApplicabilityStatus, PreregLinkInfo } from '@osf/features/preprints/enums';
1414
import { PreprintProviderDetails } from '@osf/features/preprints/models';
15-
import { FetchPreprintById, PreprintSelectors } from '@osf/features/preprints/store/preprint';
15+
import { FetchPreprintDetails, PreprintSelectors } from '@osf/features/preprints/store/preprint';
1616
import { ContributorsListComponent } from '@osf/shared/components/contributors-list/contributors-list.component';
1717
import { LicenseDisplayComponent } from '@osf/shared/components/license-display/license-display.component';
1818
import { TruncatedTextComponent } from '@osf/shared/components/truncated-text/truncated-text.component';
@@ -51,7 +51,7 @@ export class PreprintTombstoneComponent implements OnDestroy {
5151
private actions = createDispatchMap({
5252
getBibliographicContributors: GetBibliographicContributors,
5353
resetContributorsState: ResetContributorsState,
54-
fetchPreprintById: FetchPreprintById,
54+
fetchPreprintById: FetchPreprintDetails,
5555
fetchSubjects: FetchSelectedSubjects,
5656
loadMoreBibliographicContributors: LoadMoreBibliographicContributors,
5757
});

0 commit comments

Comments
 (0)