Always call wait() on subprocesses before closing stdout/stderr streams

Fixes (detected by python 3.6):

Exception ignored in: <bound method Popen.__del__ of <subprocess.Popen object at 0x105075128>>
Traceback (most recent call last):
  File "/usr/local/Cellar/python3/3.6.0/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 761, in __del__
    ResourceWarning, source=self)
ResourceWarning: subprocess 83285 is still running

Author: iMichka

pygccxml/parser/config.py

@@ -443,6 +443,7 @@ def create_compiler_path(xml_generator, compiler_path):
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE)
             compiler_path = p.stdout.read().decode("utf-8").rstrip()
+            p.wait()
             p.stdout.close()
             p.stderr.close()
             # No mscv found; look for mingw
@@ -452,6 +453,7 @@ def create_compiler_path(xml_generator, compiler_path):
                     stdout=subprocess.PIPE,
                     stderr=subprocess.PIPE)
                 compiler_path = p.stdout.read().decode("utf-8").rstrip()
+                p.wait()
                 p.stdout.close()
                 p.stderr.close()
         else:
@@ -462,6 +464,7 @@ def create_compiler_path(xml_generator, compiler_path):
                 stdout=subprocess.PIPE,
                 stderr=subprocess.PIPE)
             compiler_path = p.stdout.read().decode("utf-8").rstrip()
+            p.wait()
             p.stdout.close()
             p.stderr.close()
             # No clang found; use gcc
@@ -471,6 +474,7 @@ def create_compiler_path(xml_generator, compiler_path):
                     stdout=subprocess.PIPE,
                     stderr=subprocess.PIPE)
                 compiler_path = p.stdout.read().decode("utf-8").rstrip()
+                p.wait()
                 p.stdout.close()
                 p.stderr.close()
 

pygccxml/parser/source_reader.py

@@ -122,6 +122,7 @@ def __create_command_line(self, source_file, xml_file):
                                  stdout=subprocess.PIPE,
                                  stderr=subprocess.PIPE)
             help = p.stdout.read().decode("utf-8")
+            p.wait()
             p.stdout.close()
             p.stderr.close()
             if "CastXML wrapper" in help:
@@ -349,6 +350,7 @@ def create_xml_file(self, source_file, destination=None):
             utils.remove_file_no_raise(xml_file, self.__config)
             raise
         finally:
+            process.wait()
             process.stdout.close()
         return xml_file
 

pygccxml/utils/utils.py

@@ -53,19 +53,22 @@ def find_xml_generator(name=None):
         p = subprocess.Popen([command, name], stdout=subprocess.PIPE,
                              stderr=subprocess.PIPE)
         path = p.stdout.read().decode("utf-8")
+        p.wait()
         p.stdout.close()
         p.stderr.close()
         if path == "":
             name = "gccxml"
             p = subprocess.Popen([command, name], stdout=subprocess.PIPE,
                                  stderr=subprocess.PIPE)
             path = p.stdout.read().decode("utf-8")
+            p.wait()
             p.stdout.close()
             p.stderr.close()
     else:
         p = subprocess.Popen([command, name], stdout=subprocess.PIPE,
                              stderr=subprocess.PIPE)
         path = p.stdout.read().decode("utf-8")
+        p.wait()
         p.stdout.close()
         p.stderr.close()
     if path == "":

unittests/file_cache_tester.py

@@ -101,6 +101,7 @@ def test_reopen_cache():
             stdout=subprocess.PIPE,
             env=env)
         print(p.stdout.read())
+        p.wait()
         p.stdout.close()