Skip to content

Commit 4c41a88

Browse files
xQwexxCalcProgrammer1
authored andcommitted
Fix some logging mistake
1 parent ef36664 commit 4c41a88

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

LogManager.cpp

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -232,14 +232,17 @@ void LogManager::_append(const char* filename, int line, unsigned int level, con
232232
/*-------------------------------------------------*\
233233
| If the message level is LL_WARNING or lower, add |
234234
| it to the error queue |
235+
| |
236+
| Commented out - It is causing OpenRGB to crash |
237+
| according to #1537 |
235238
\*-------------------------------------------------*/
236-
if(level <= LL_WARNING)
237-
{
238-
for(size_t idx = 0; idx < error_callbacks.size(); ++idx)
239-
{
240-
error_callbacks[idx].first(error_callbacks[idx].second, mes);
241-
}
242-
}
239+
//if(level <= LL_WARNING)
240+
//{
241+
// for(size_t idx = 0; idx < error_callbacks.size(); ++idx)
242+
// {
243+
// error_callbacks[idx].first(error_callbacks[idx].second, mes);
244+
// }
245+
//}
243246
}
244247

245248
void LogManager::append(const char* filename, int line, unsigned int level, const char* fmt, ...)

ResourceManager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -899,7 +899,7 @@ void ResourceManager::DetectDevicesThreadFunction()
899899
{
900900
const char* manu_name = wchar_to_char(current_hid_device->manufacturer_string);
901901
const char* prod_name = wchar_to_char(current_hid_device->product_string);
902-
LOG_DEBUG("[%04X:%04X U=%3X P=0x%04X I=%d] %-25s - %s", current_hid_device->vendor_id, current_hid_device->product_id, current_hid_device->usage, current_hid_device->usage_page, current_hid_device->interface_number, manu_name, prod_name);
902+
LOG_DEBUG("[%04X:%04X U=%04X P=0x%04X I=%d] %-25s - %s", current_hid_device->vendor_id, current_hid_device->product_id, current_hid_device->usage, current_hid_device->usage_page, current_hid_device->interface_number, manu_name, prod_name);
903903
}
904904
detection_string = "";
905905
DetectionProgressChanged();

0 commit comments

Comments
 (0)