Added tests for materials

Author: adrianschneider94

.gitignore

@@ -38,3 +38,6 @@ out1.3mf
 out2.3mf
 out3.3mf
 orig.dxf
+box.brep
+sketch.dxf
+material_test*

cadquery/occ_impl/assembly.py

@@ -404,10 +404,9 @@ def toVTKAssy(
                 actor.GetProperty().SetMetallic(element.material.pbr.metallic)
                 actor.GetProperty().SetRoughness(element.material.pbr.roughness)
                 actor.GetProperty().SetBaseIOR(element.material.pbr.refraction_index)
-                if element.material.pbr.emissive_factor:
-                    actor.GetProperty().SetEmissiveFactor(
-                        *element.material.pbr.emissive_factor.rgb()
-                    )
+                actor.GetProperty().SetEmissiveFactor(
+                    *element.material.pbr.emissive_factor.rgb()
+                )
 
         rv.AddPart(actor)
 
@@ -481,10 +480,9 @@ def toVTK(
                 actor.GetProperty().SetMetallic(element.material.pbr.metallic)
                 actor.GetProperty().SetRoughness(element.material.pbr.roughness)
                 actor.GetProperty().SetBaseIOR(element.material.pbr.refraction_index)
-                if element.material.pbr.emissive_factor:
-                    actor.GetProperty().SetEmissiveFactor(
-                        *element.material.pbr.emissive_factor.rgb()
-                    )
+                actor.GetProperty().SetEmissiveFactor(
+                    *element.material.pbr.emissive_factor.rgb()
+                )
 
         renderer.AddActor(actor)
 
@@ -537,10 +535,9 @@ def toJSON(
                     "roughness": element.material.pbr.roughness,
                     "refraction_index": element.material.pbr.refraction_index,
                 }
-                if element.material.pbr.emissive_factor:
-                    val["material"]["pbr"][
-                        "emissive_factor"
-                    ] = element.material.pbr.emissive_factor.rgba()
+                val["material"]["pbr"][
+                    "emissive_factor"
+                ] = element.material.pbr.emissive_factor.rgba()
 
         rv.append(val)
 

examples/Ex027_Materials.py

@@ -69,10 +69,13 @@
 assy.add(cube.translate((30, 0, 0)), name="glass_cube", material=glass_material)
 assy.add(cube.translate((45, 0, 0)), name="gold_cube", material=gold_material)
 
-# Export as OBJ and GLTF to showcase materials
-assy.export("materials.step")  # STEP format
-exportStepMeta(assy, "materials_meta.step")  # STEP format with metadata
-assy.export("materials.glb")  # GLTF format (binary) with PBR materials
+# Different formats support different material properties:
+# - STEP: Only supports colors and basic material properties like density
+# - OBJ: Supports common materials (ambient, diffuse, specular etc.)
+# - GLTF: Full support for PBR materials
+#
+# The best representation can be achieved with gltf:
+# assy.export("materials.glb")
 
 # Show the assembly in the UI
 show_object(assy)

tests/test_assembly.py

@@ -16,7 +16,7 @@
     exportVTKJS,
     exportVRML,
 )
-from cadquery.occ_impl.assembly import toJSON, toCAF, toFusedCAF, color_to_occt
+from cadquery.occ_impl.assembly import toJSON, toCAF, toFusedCAF
 from cadquery.occ_impl.shapes import Face, box, cone
 
 from OCP.gp import gp_XYZ