cr

Author: ilanskogan

src/engine.js

@@ -50,7 +50,6 @@ class Engine extends EventEmitter {
       rule = new Rule(properties)
     }
     rule.setEngine(this)
-    if (!rule.id) rule.id = '_' + Math.random().toString(36).substr(2, 9)
     this.rules.push(rule)
     this.prioritizedRules = null
     return this

src/rule.js

@@ -36,9 +36,7 @@ class Rule extends EventEmitter {
       this.setName(options.name)
     }
 
-    if (options && (options.id)) {
-      this.setId(options.id)
-    }
+    this.setId(options ? options.id : null)
 
     const priority = (options && options.priority) || 1
     this.setPriority(priority)
@@ -63,10 +61,11 @@ class Rule extends EventEmitter {
    * @param {any} id - any truthy input
    */
   setId (id) {
-    if (!id && id !== 0) {
-      throw new Error('Rule "id" must be defined')
+    if (!id) {
+      this.id = '_' + Math.random().toString(36).substr(2, 9)
+    } else {
+      this.id = id
     }
-    this.id = id
     return this
   }
 

test/engine.test.js

@@ -93,6 +93,11 @@ describe('Engine', () => {
       engine.updateRule(rule)
       expect(engine.rules[0].conditions.all.length).to.equal(0)
     })
+    it('should generate id for rule if not provided', () => {
+      const rule = new Rule(factories.rule())
+      expect(rule.id).to.not.equal(null)
+      expect(rule.id).to.not.equal(undefined)
+    })
     it('should throw error if rule not found', () => {
       const rule1 = new Rule(factories.rule())
       engine.addRule(rule1)