confused

Author: CTTY

crates/iceberg/src/spec/manifest/entry.rs

@@ -130,12 +130,6 @@ impl ManifestEntry {
         self.snapshot_id
     }
 
-    /// File sequence number
-    #[inline]
-    pub fn file_sequence_number(&self) -> Option<i64> {
-        self.file_sequence_number
-    }
-
     /// Data sequence number.
     #[inline]
     pub fn sequence_number(&self) -> Option<i64> {

crates/iceberg/src/transaction/rewrite_files.rs

@@ -143,6 +143,7 @@ impl TransactionAction for RewriteFilesAction {
 }
 
 fn copy_with_deleted_status(entry: &ManifestEntryRef) -> Result<ManifestEntry> {
+    // todo should we fail on missing properties?
     let builder = ManifestEntry::builder()
         .status(ManifestStatus::Deleted)
         .snapshot_id(entry.snapshot_id().ok_or_else(|| {
@@ -163,15 +164,8 @@ fn copy_with_deleted_status(entry: &ManifestEntryRef) -> Result<ManifestEntry> {
                 ),
             )
         })?)
-        .file_sequence_number(entry.file_sequence_number().ok_or_else(|| {
-            Error::new(
-                ErrorKind::DataInvalid,
-                format!(
-                    "Missing file_sequence_number for entry with file path: {}",
-                    entry.file_path()
-                ),
-            )
-        })?)
+        // todo copy file seq no as well
+        
         .data_file(entry.data_file().clone());
 
     Ok(builder.build())