ensure the parse order is reset on clear() (#1218)

phlptp · web-flow · commit e591f4aac506 · 2025-10-03T06:08:47.000-07:00
Fixes #1216
diff --git a/include/CLI/impl/App_inl.hpp b/include/CLI/impl/App_inl.hpp
@@ -582,6 +582,7 @@ CLI11_INLINE void App::clear() {
 
     missing_.clear();
     parsed_subcommands_.clear();
+    parse_order_.clear();
     for(const Option_p &opt : options_) {
         opt->clear();
     }
diff --git a/tests/AppTest.cpp b/tests/AppTest.cpp
@@ -2016,6 +2016,8 @@ TEST_CASE_METHOD(TApp, "OriginalOrder", "[app]") {
     CHECK(std::vector<int>({2}) == st2);
 
     CHECK(std::vector<CLI::Option *>({op1, op2, op1, op1}) == app.parse_order());
+    app.clear();
+    CHECK(app.parse_order().empty());
 }
 
 TEST_CASE_METHOD(TApp, "NeedsFlags", "[app]") {

Original file line number	Diff line number	Diff line change
`@@ -582,6 +582,7 @@ CLI11_INLINE void App::clear() {`
`582`	`582`
`583`	`583`	`missing_.clear();`
`584`	`584`	`parsed_subcommands_.clear();`
	`585`	`+ parse_order_.clear();`
`585`	`586`	`for(const Option_p &opt : options_) {`
`586`	`587`	`opt->clear();`
`587`	`588`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2016,6 +2016,8 @@ TEST_CASE_METHOD(TApp, "OriginalOrder", "[app]") {`
`2016`	`2016`	`CHECK(std::vector<int>({2}) == st2);`
`2017`	`2017`
`2018`	`2018`	`CHECK(std::vector<CLI::Option *>({op1, op2, op1, op1}) == app.parse_order());`
	`2019`	`+ app.clear();`
	`2020`	`+ CHECK(app.parse_order().empty());`
`2019`	`2021`	`}`
`2020`	`2022`
`2021`	`2023`	`TEST_CASE_METHOD(TApp, "NeedsFlags", "[app]") {`