internal: fix crash inside filter_unnecessary_bounds for a missing generic param

davidbarsky · davidbarsky · commit 2d09d69fbedc · 2024-02-08T20:58:48.000-05:00
diff --git a/crates/ide-assists/src/handlers/generate_function.rs b/crates/ide-assists/src/handlers/generate_function.rs
@@ -908,7 +908,7 @@ fn filter_unnecessary_bounds(
         }
     }
 
-    let starting_nodes = necessary_params.iter().map(|param| param_map[param]);
+    let starting_nodes = necessary_params.iter().flat_map(|param| param_map.get(param).copied());
     let reachable = graph.compute_reachable_nodes(starting_nodes);
 
     // Not pretty, but effective. If only there were `Vec::retain_index()`...

Original file line number	Diff line number	Diff line change
`@@ -908,7 +908,7 @@ fn filter_unnecessary_bounds(`
`908`	`908`	`}`
`909`	`909`	`}`
`910`	`910`
`911`		`- let starting_nodes = necessary_params.iter().map(\|param\| param_map[param]);`
	`911`	`+ let starting_nodes = necessary_params.iter().flat_map(\|param\| param_map.get(param).copied());`
`912`	`912`	`let reachable = graph.compute_reachable_nodes(starting_nodes);`
`913`	`913`
`914`	`914`	// Not pretty, but effective. If only there were `Vec::retain_index()`...