Incorrect await usage in TimerRingController causes build failure & possible crash #855
+105
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move .value) to prevent crash on ring start
Author
|
The code is updated and tested locally; requesting review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TimerRingController misused await and accessed properties on a Future, leading to compile-time errors and a potential null crash.
Problematic lines:
AudioUtils.playTimer(alarmRecord: await getFakeTimerModel().value); // .value on a Future
AudioUtils.stopTimer(ringtoneName: await getFakeTimerModel().ringtoneName); // property access before await
vibrationTimer!.cancel(); // potential null crash
Impact:
Build fails with type/property errors.
Possible runtime crash if vibrationTimer is null.
What I tried
Reproduced by launching a timer ring; build failed due to the incorrect .value and property access on a Future. Verified crash risk by inspecting vibrationTimer.