Skip to content

Commit d4a2510

Browse files
committed
Modify unit tests to run tests only after build success
1 parent 2ead8d3 commit d4a2510

File tree

1 file changed

+8
-7
lines changed

1 file changed

+8
-7
lines changed

tests/test_ci/TestControllers.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,8 @@ def test_customizedtest_added_to_queue(self):
390390
g.db.commit()
391391
import mod_ci.controllers
392392
reload(mod_ci.controllers)
393-
from mod_ci.controllers import queue_test
393+
from mod_ci.controllers import add_test_entry, queue_test
394+
add_test_entry(g.db, None, 'customizedcommitcheck', TestType.commit)
394395
queue_test(g.db, None, 'customizedcommitcheck', TestType.commit)
395396
test = Test.query.filter(Test.id == 3).first()
396397
customized_test = test.get_customized_regressiontests()
@@ -637,10 +638,10 @@ def test_webhook_push_no_after(self, mock_request):
637638
data=json.dumps(data), headers=self.generate_header(data, 'push'))
638639

639640
@mock.patch('requests.get', side_effect=mock_api_request_github)
640-
@mock.patch('mod_ci.controllers.queue_test')
641+
@mock.patch('mod_ci.controllers.add_test_entry')
641642
@mock.patch('mod_ci.controllers.GitHub')
642643
@mock.patch('mod_ci.controllers.GeneralData')
643-
def test_webhook_push_valid(self, mock_gd, mock_github, mock_queue_test, mock_request):
644+
def test_webhook_push_valid(self, mock_gd, mock_github, mock_add_test_entry, mock_request):
644645
"""Test webhook triggered with push event with valid data."""
645646
data = {'after': 'abcdefgh'}
646647
with self.app.test_client() as c:
@@ -650,7 +651,7 @@ def test_webhook_push_valid(self, mock_gd, mock_github, mock_queue_test, mock_re
650651

651652
mock_gd.query.filter.assert_called()
652653
mock_github.assert_called_once()
653-
mock_queue_test.assert_called_once()
654+
mock_add_test_entry.assert_called_once()
654655

655656
@mock.patch('mod_ci.controllers.Test')
656657
@mock.patch('requests.get', side_effect=mock_api_request_github)
@@ -694,9 +695,9 @@ def __init__(self):
694695

695696
@mock.patch('mod_ci.controllers.BlockedUsers')
696697
@mock.patch('mod_ci.controllers.GitHub')
697-
@mock.patch('mod_ci.controllers.queue_test')
698+
@mock.patch('mod_ci.controllers.add_test_entry')
698699
@mock.patch('requests.get', side_effect=mock_api_request_github)
699-
def test_webhook_pr_opened(self, mock_request, mock_queue_test, mock_github, mock_blocked):
700+
def test_webhook_pr_opened(self, mock_request, mock_add_test_entry, mock_github, mock_blocked):
700701
"""Test webhook triggered with pull_request event with opened action."""
701702
mock_blocked.query.filter.return_value.first.return_value = None
702703

@@ -709,7 +710,7 @@ def test_webhook_pr_opened(self, mock_request, mock_queue_test, mock_github, moc
709710

710711
self.assertEqual(response.data, b'{"msg": "EOL"}')
711712
mock_blocked.query.filter.assert_called_once_with(mock_blocked.user_id == 'test')
712-
mock_queue_test.assert_called_once()
713+
mock_add_test_entry.assert_called_once()
713714

714715
@mock.patch('mod_ci.controllers.inform_mailing_list')
715716
@mock.patch('requests.get', side_effect=mock_api_request_github)

0 commit comments

Comments
 (0)