Skip to content

Commit dbbe00a

Browse files
committed
[build] Bump minimum Ubuntu build version
1 parent f57b64d commit dbbe00a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ jobs:
2626
runs-on: ${{ matrix.os }}
2727
strategy:
2828
matrix:
29-
# TODO: Bump ubuntu 20 to 22 when past EOL date.
30-
os: [macos-13, macos-14, ubuntu-20.04, ubuntu-latest, windows-latest]
29+
os: [macos-13, macos-14, ubuntu-22.04, ubuntu-latest, windows-latest]
3130
python-version: ["3.7", "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
3231
exclude:
3332
# macos-14 builders use M1 (ARM64) which does not have a Python 3.7 package available.

scenedetect/common.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,9 @@ def __init__(
209209
else:
210210
self._frame_num = self._parse_timecode_number(timecode)
211211

212+
# TODO(v0.7): Add a PTS property as well and slowly transition over to that, since we don't
213+
# always know the position as a "frame number". However, for the reverse case, we CAN state
214+
# the presentation time if we know the frame number (for a fixed framerate video).
212215
@property
213216
def frame_num(self) -> ty.Optional[int]:
214217
return self._frame_num

0 commit comments

Comments
 (0)