[scene_manager] Fix incorrect frame check #455

We cannot check if the frame is boolean due to ambiguity, so we must test both cases. #454 #455

Author: Breakthrough

scenedetect/scene_manager.py

@@ -541,7 +541,7 @@ def save_images(
         for j, image_timecode in enumerate(scene_timecodes):
             video.seek(image_timecode)
             frame_im = video.read()
-            if frame_im is not None:
+            if frame_im is not None and frame_im is not False:
                 # TODO: Add extension to template.
                 # TODO: Allow NUM to be a valid suffix in addition to NUMBER.
                 file_path = "%s.%s" % (

website/pages/changelog.md

@@ -584,6 +584,7 @@ Development
 ## PySceneDetect 0.6.5 (TBD)
 
  - [bugfix] Fix new detectors not working with `default-detector` config option
+ - [bugfix] Fix crash when using `save-images` with OpenCV backend [#455](https://github.com/Breakthrough/PySceneDetect/issues/455)
  - [bugfix] Fix `SyntaxWarning` due to incorrect escaping [#400](https://github.com/Breakthrough/PySceneDetect/issues/400)
  - [bugfix] Fix `ContentDetector` crash when using callbacks [#416](https://github.com/Breakthrough/PySceneDetect/issues/416) [#420](https://github.com/Breakthrough/PySceneDetect/issues/420)
  - [general] Timecodes of the form `MM:SS[.nnn]` are now processed correctly [#443](https://github.com/Breakthrough/PySceneDetect/issues/443)