[save-edl] Remove PTS correction in end timestamp calculation #516

Author: Breakthrough

scenedetect/_cli/commands.py

@@ -292,7 +292,7 @@ def get_edl_timecode(timecode: FrameTimecode):
     # Add each shot as an edit entry
     for i, (start, end) in enumerate(scenes):
         in_tc = get_edl_timecode(start)
-        out_tc = get_edl_timecode(end - 1)  # Correct for presentation time
+        out_tc = get_edl_timecode(end)  # Correct for presentation time
         # Format the edit entry according to CMX 3600 format
         event_line = f"{(i + 1):03d}  {reel} V     C        {in_tc} {out_tc} {in_tc} {out_tc}"
         edl_content.append(event_line)

tests/test_cli.py

@@ -104,7 +104,7 @@ def invoke_scenedetect(
     if config_file:
         command += " -c %s" % config_file
     command += " " + args.format(**value_dict)
-    return subprocess.call(command.strip().split(" "))
+    return subprocess.call(command.strip().split(" "), shell=True)
 
 
 def test_cli_no_args():
@@ -757,8 +757,8 @@ def test_cli_save_edl(tmp_path: Path):
 TITLE: {DEFAULT_VIDEO_NAME}
 FCM: NON-DROP FRAME
 
-001  AX V     C        00:00:02:00 00:00:03:17 00:00:02:00 00:00:03:17
-002  AX V     C        00:00:03:18 00:00:05:23 00:00:03:18 00:00:05:23
+001  AX V     C        00:00:02:00 00:00:03:18 00:00:02:00 00:00:03:18
+002  AX V     C        00:00:03:18 00:00:06:00 00:00:03:18 00:00:06:00
 """
     assert output_path.read_text() == EXPECTED_EDL_OUTPUT
 
@@ -778,8 +778,8 @@ def test_cli_save_edl_with_params(tmp_path: Path):
 TITLE: title
 FCM: NON-DROP FRAME
 
-001  BX V     C        00:00:02:00 00:00:03:17 00:00:02:00 00:00:03:17
-002  BX V     C        00:00:03:18 00:00:05:23 00:00:03:18 00:00:05:23
+001  BX V     C        00:00:02:00 00:00:03:18 00:00:02:00 00:00:03:18
+002  BX V     C        00:00:03:18 00:00:06:00 00:00:03:18 00:00:06:00
 """
     assert output_path.read_text() == EXPECTED_EDL_OUTPUT