Fix bug with LSTM model initialization #952
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes BrainJS#948 Initialize the `equations` property in the `LSTM` class constructor in `src/recurrent/lstm.ts`. * Ensure the `equations` property is properly populated before it is accessed in the `get` method of the `LSTM` class. * Initialize the `equations` property in the `LSTMTimeStep` class constructor in `src/recurrent/lstm-time-step.ts`. * Ensure the `equations` property is properly populated before it is accessed in the `getEquation` method of the `LSTMTimeStep` class. * Add test cases in `src/recurrent/lstm-time-step.test.ts` to verify that the `equations` property is properly initialized and populated. * Add end-to-end test cases in `src/recurrent/lstm-time-step.end-to-end.test.ts` to verify that the LSTM model correctly trains and produces the expected output values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948
Initialize the
equationsproperty in theLSTMclass constructor insrc/recurrent/lstm.ts.equationsproperty is properly populated before it is accessed in thegetmethod of theLSTMclass.equationsproperty in theLSTMTimeStepclass constructor insrc/recurrent/lstm-time-step.ts.equationsproperty is properly populated before it is accessed in thegetEquationmethod of theLSTMTimeStepclass.src/recurrent/lstm-time-step.test.tsto verify that theequationsproperty is properly initialized and populated.src/recurrent/lstm-time-step.end-to-end.test.tsto verify that the LSTM model correctly trains and produces the expected output values.