free should happen after omp_target_disassociate_ptr

Pramod Kumbhar · olupton · commit 52711dc8bb58 · 2021-12-10T06:49:22.000+01:00
diff --git a/coreneuron/gpu/nrn_acc_manager.cpp b/coreneuron/gpu/nrn_acc_manager.cpp
@@ -83,9 +83,8 @@ void cnrn_target_delete(void* h_ptr, size_t len) {
     {
         d_ptr = h_ptr;
     }
-    // todo: disassociate first or free first
-    omp_target_free(d_ptr, device_id);
     omp_target_disassociate_ptr(h_ptr, device_id);
+    omp_target_free(d_ptr, device_id);
 #else
     throw std::runtime_error("cnrn_target_delete() not implemented without OpenACC/OpenMP and gpu build");
 #endif

Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,8 @@ void cnrn_target_delete(void* h_ptr, size_t len) {`
`83`	`83`	`{`
`84`	`84`	`d_ptr = h_ptr;`
`85`	`85`	`}`
`86`		`- // todo: disassociate first or free first`
`87`		`- omp_target_free(d_ptr, device_id);`
`88`	`86`	`omp_target_disassociate_ptr(h_ptr, device_id);`
	`87`	`+ omp_target_free(d_ptr, device_id);`
`89`	`88`	`#else`
`90`	`89`	`throw std::runtime_error("cnrn_target_delete() not implemented without OpenACC/OpenMP and gpu build");`
`91`	`90`	`#endif`