Merge #37: Encrypt ECDSA signatures in release builds

e869210 Encrypt ECDSA adaptor signatures in release builds (Mariusz Klochowicz)
150669b Add CI job for running tests in release mode to show failing testcases (Mariusz Klochowicz)

Pull request description:

ACKs for top commit:
  thomaseizinger:
    ACK e869210
  jonasnick:
    ACK e869210

Tree-SHA512: 9d9a9b5af1f8bf8effa9bf7b96755a4b08e096febc764e7e4ba36e5e77c987a632200de018f1cf292ae156008ee2b2d03462a03537faebeaca1890e0f769b460

Author: jonasnick

.github/workflows/rust.yml

@@ -103,3 +103,32 @@ jobs:
           DO_FEATURE_MATRIX: true
         run: ./contrib/test.sh
 
+  ReleaseTests:
+    name: Release tests with global context enabled
+    strategy:
+      matrix:
+        rust:
+          - 1.29.0
+          - beta
+          - stable
+        target: [ x86_64-unknown-linux-gnu, x86_64-apple-darwin ]
+        include:
+          - target: x86_64-unknown-linux-gnu
+            os: ubuntu-latest
+          - target: x86_64-apple-darwin
+            os: macos-latest
+    runs-on: ${{ matrix.os }}
+    steps:
+      - name: Checkout Crate
+        uses: actions/checkout@v2
+      - name: Checkout Toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: ${{ matrix.rust }}
+          override: true
+      - name: Pin cc if rust 1.29
+        if: matrix.rust == '1.29.0'
+        run: cargo generate-lockfile --verbose && cargo update -p cc --precise "1.0.41" --verbose
+      - name: Running cargo in release mode
+        run: cargo test --features="global-context" --release

src/zkp/ecdsa_adaptor.rs

@@ -167,19 +167,18 @@ impl EcdsaAdaptorSignature {
     ) -> EcdsaAdaptorSignature {
         let mut adaptor_sig = ffi::EcdsaAdaptorSignature::new();
 
-        unsafe {
-            debug_assert!(
-                ffi::secp256k1_ecdsa_adaptor_encrypt(
-                    *secp.ctx(),
-                    &mut adaptor_sig,
-                    sk.as_c_ptr(),
-                    enckey.as_c_ptr(),
-                    msg.as_c_ptr(),
-                    ffi::secp256k1_nonce_function_ecdsa_adaptor,
-                    ptr::null_mut(),
-                ) == 1
-            );
+        let res = unsafe {
+            ffi::secp256k1_ecdsa_adaptor_encrypt(
+                *secp.ctx(),
+                &mut adaptor_sig,
+                sk.as_c_ptr(),
+                enckey.as_c_ptr(),
+                msg.as_c_ptr(),
+                ffi::secp256k1_nonce_function_ecdsa_adaptor,
+                ptr::null_mut(),
+            )
         };
+        debug_assert_eq!(res, 1);
 
         EcdsaAdaptorSignature(adaptor_sig)
     }
@@ -197,19 +196,19 @@ impl EcdsaAdaptorSignature {
     ) -> EcdsaAdaptorSignature {
         let mut adaptor_sig = ffi::EcdsaAdaptorSignature::new();
 
-        unsafe {
-            debug_assert!(
-                ffi::secp256k1_ecdsa_adaptor_encrypt(
-                    *secp.ctx(),
-                    &mut adaptor_sig,
-                    sk.as_c_ptr(),
-                    enckey.as_c_ptr(),
-                    msg.as_c_ptr(),
-                    ffi::secp256k1_nonce_function_ecdsa_adaptor,
-                    aux_rand.as_c_ptr() as *mut ffi::types::c_void,
-                ) == 1
-            );
+        let res = unsafe {
+            ffi::secp256k1_ecdsa_adaptor_encrypt(
+                *secp.ctx(),
+                &mut adaptor_sig,
+                sk.as_c_ptr(),
+                enckey.as_c_ptr(),
+                msg.as_c_ptr(),
+                ffi::secp256k1_nonce_function_ecdsa_adaptor,
+                aux_rand.as_c_ptr() as *mut ffi::types::c_void,
+            )
         };
+        debug_assert_eq!(res, 1);
+
         EcdsaAdaptorSignature(adaptor_sig)
     }