Fixes

Author: GrahamCampbell

phpstan-baseline.neon

@@ -1,8 +1,8 @@
 parameters:
 	ignoreErrors:
 		-
-			message: '#^Property Bitbucket\\Api\\AbstractApi\:\:\$perPage is never written, only read\.$#'
-			identifier: property.onlyRead
+			message: '#^Property Bitbucket\\Api\\AbstractApi\:\:\$perPage \(int\|null\) is never assigned int so it can be removed from the property type\.$#'
+			identifier: property.unusedType
 			count: 1
 			path: src/Api/AbstractApi.php
 

tests/ApiUrlTest.php

@@ -8,6 +8,7 @@
 use Bitbucket\HttpClient\Builder;
 use Http\Mock\Client as MockClient;
 use PHPUnit\Framework\TestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 
 /**
  * Tests API URLs constructed in Src and Downloads API classes.
@@ -23,12 +24,7 @@ public function setUp(): void
         $this->client = new Client(new Builder($this->httpClient));
     }
 
-    /**
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Src::show
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Src::buildSrcUri
-     *
-     * @dataProvider dataProvider
-     */
+    #[DataProvider('dataProvider')]
     public function testWorkspaceSrcShowUri(string $fileName): void
     {
         $this->client->repositories()
@@ -42,12 +38,7 @@ public function testWorkspaceSrcShowUri(string $fileName): void
         );
     }
 
-    /**
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Src::download
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Src::buildSrcUri
-     *
-     * @dataProvider dataProvider
-     */
+    #[DataProvider('dataProvider')]
     public function testWorkspaceSrcDownloadUri(string $fileName): void
     {
         $this->client->repositories()
@@ -61,12 +52,7 @@ public function testWorkspaceSrcDownloadUri(string $fileName): void
         );
     }
 
-    /**
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Downloads::download
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Downloads::buildDownloadsUri
-     *
-     * @dataProvider dataProvider
-     */
+    #[DataProvider('dataProvider')]
     public function testWorkspaceDownloadUri(string $fileName): void
     {
         $this->client->repositories()
@@ -80,12 +66,7 @@ public function testWorkspaceDownloadUri(string $fileName): void
         );
     }
 
-    /**
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Downloads::remove
-     * @covers \Bitbucket\Api\Repositories\Workspaces\Downloads::buildDownloadsUri
-     *
-     * @dataProvider dataProvider
-     */
+    #[DataProvider('dataProvider')]
     public function testWorkspaceRemoveUri(string $fileName): void
     {
         $this->client->repositories()