Merge branch 'unit-test-simple-address'

Author: benma

src/rust/bitbox02-rust/src/hww/api/bitcoin.rs

@@ -385,5 +385,30 @@ mod tests {
                 }))),
             );
         }
+
+        // --- Negative tests
+        mock_unlocked();
+        // First check a valid request:
+        let req = pb::BtcPubRequest {
+            coin: BtcCoin::Btc as _,
+            keypath: [49 + HARDENED, 0 + HARDENED, 1 + HARDENED, 1, 100].to_vec(),
+            display: false,
+            output: Some(Output::ScriptConfig(BtcScriptConfig {
+                config: Some(Config::SimpleType(SimpleType::P2wpkhP2sh as _)),
+            })),
+        };
+        assert!(block_on(process_pub(&req)).unwrap().is_ok());
+        // -- Wrong coin: MIN-1
+        let mut req_invalid = req.clone();
+        req_invalid.coin = BtcCoin::Btc as i32 - 1;
+        assert!(block_on(process_pub(&req_invalid)).unwrap().is_err());
+        // -- Wrong coin: MAX + 1
+        let mut req_invalid = req.clone();
+        req_invalid.coin = BtcCoin::Tltc as i32 + 1;
+        assert!(block_on(process_pub(&req_invalid)).unwrap().is_err());
+        // -- Wrong keypath
+        let mut req_invalid = req.clone();
+        req_invalid.keypath = [49 + HARDENED, 0 + HARDENED, 1 + HARDENED, 1, 10000].to_vec();
+        assert!(block_on(process_pub(&req_invalid)).unwrap().is_err());
     }
 }

test/unit-test/CMakeLists.txt

@@ -227,8 +227,6 @@ set(TEST_LIST
    "-Wl,--wrap=rand,--wrap=wally_sha256"
    apps_common_bip32
    ""
-   app_btc
-   "-Wl,--wrap=keystore_secp256k1_pubkey_hash160,--wrap=btc_common_is_valid_keypath_address_simple,--wrap=btc_common_outputhash_from_pubkeyhash"
    app_btc_multisig
    "-Wl,--wrap=memory_multisig_get_by_hash,--wrap=apps_btc_confirm_multisig_basic"
    app_btc_common