Commit 590e5f5
committed
wallet-connect: fix ui crash when account unspecified by dapp
some dapps may not populate Wallet Connect's Session Namespaces with
data about which account they are connecting to
while this is not recommended behavior, it is up to the wallet software to
handle (as per wallet connect namespace documentation)
since the user can have multiple accounts in the bitbox app, we rely
on the namespaces to show which one of these accounts the WC dapp
session is connected to, however, the session should work even in
absence of this information so we show "Unspecified account" instead
when the dapp doesn't provide this session information1 parent 034a351 commit 590e5f5
File tree
3 files changed
+13
-10
lines changed- frontends/web/src
- locales/en
- routes/account/walletconnect
- components/session-card
3 files changed
+13
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1759 | 1759 | | |
1760 | 1760 | | |
1761 | 1761 | | |
1762 | | - | |
| 1762 | + | |
| 1763 | + | |
1763 | 1764 | | |
1764 | 1765 | | |
1765 | 1766 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
Lines changed: 10 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
117 | 119 | | |
118 | 120 | | |
119 | 121 | | |
| |||
0 commit comments