Skip to content

Commit 494f03c

Browse files
committed
frontend/android: push min sdk version to 24 (Android 7)
Some of the calls used in the code (e.g. those that fetch the native locale of the device) require sdk versions 24.
1 parent 015b144 commit 494f03c

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

backend/mobileserver/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ include ../../version.mk.inc
44
# Set -glflags to fix the vendor issue with gomobile, see: https://github.com/golang/go/issues/67927#issuecomment-2241523694
55
build-android:
66
# androidapi version should match minSdkVersion in frontends/android/BitBoxApp/app/build.gradle
7-
ANDROID_HOME=${ANDROID_SDK_ROOT} gomobile bind -x -a -glflags="-mod=readonly" -ldflags="-s -w $(GO_VERSION_LDFLAGS)" -trimpath -target android -androidapi 21 .
7+
ANDROID_HOME=${ANDROID_SDK_ROOT} gomobile bind -x -a -glflags="-mod=readonly" -ldflags="-s -w $(GO_VERSION_LDFLAGS)" -trimpath -target android -androidapi 24 .
88
build-ios:
99
gomobile bind -x -a -glflags="-mod=readonly" -tags="timetzdata" -trimpath -ldflags="-s -w $(GO_VERSION_LDFLAGS)" -target ios,iossimulator .
1010
clean:

frontends/android/BitBoxApp/app/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ android {
1313
ndkVersion "28.2.13676358"
1414
defaultConfig {
1515
applicationId "ch.shiftcrypto.bitboxapp"
16+
minSdk 24
1617
// minSdkVersion should match the `-androidapi` gomobile bind flag
1718
// in backend/mobileserver/Makefile
18-
minSdkVersion 21
1919
targetSdkVersion 35
2020
versionCode 66
2121
versionName "${appVersion}"

0 commit comments

Comments
 (0)