🐛 in iscanonical / canonical

Fixes #225

Add tests for edge case

Fixup

Fiixup

🐛 in iscanonical / canonical
Fixes #225

🐛 in iscanonical / canonical
Fixes #225

Update Project.toml

Author: Ben J. Ward

CHANGELOG.md

@@ -4,6 +4,14 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [3.0.1]
+### Removed
+
+### Added
+
+### Changed
+- Fixed a bug in `iscanonical`.
+
 ## [3.0]
 ### Removed
 - Removed `unsafe_setindex!`. Instead, use normal setindex with `@inbounds`.

Project.toml

@@ -1,7 +1,7 @@
 name = "BioSequences"
 uuid = "7e6ae17a-c86d-528c-b3b9-7f778a29fe59"
 authors = ["Sabrina Jaye Ward <sabrinajward@protonmail.com>", "Jakob Nissen <jakobnybonissen@gmail.com>"]
-version = "3.0.0"
+version = "3.0.1"
 
 [deps]
 BioSymbols = "3c28c6f8-a34d-59c4-9654-267d177fcfa9"

src/biosequence/predicates.jl

@@ -115,7 +115,7 @@ two i.e. `canonical_seq < other_seq`.
 function iscanonical(seq::NucleotideSeq)
     i = 1
     j = lastindex(seq)
-    @inbounds while i < j
+    @inbounds while i <= j
         f = seq[i]
         r = complement(seq[j])
         f < r && return true

test/biosequences/misc.jl

@@ -126,6 +126,9 @@ end
     seq = SimpleSeq("CGAU")
     canonical!(seq)
     @test seq == SimpleSeq("AUCG")
+
+    @test iscanonical(SimpleSeq("UCA"))
+    @test !iscanonical(SimpleSeq("UGA"))
 end
 
 @testset "Ispalindromic" begin

test/longsequences/predicates.jl

@@ -75,4 +75,8 @@
     @test  isrepetitive(aa"PGQQ", 2)
     @test !isrepetitive(aa"PPQQ", 3)
     @test  isrepetitive(aa"PPPQQ", 3)
+
+    # iscanonical
+    @test iscanonical(dna"TCA")
+    @test !iscanonical(dna"TGA")
 end