Upgrade Mybatis-Migration support to 3.3.7 to work around an error in… #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…troduced by mybatis/migrations@a5d8a72#diff-2c0b0afa4090a13167224923f2536046. Also by checking if the script file exists before creating a MigrationReader, code now handles case when onabort.sql isn't found.
Author
|
@Bessonov Any thoughts on this PR? I see that the CI checks failed, but it doesn't look to have anything to do with the changes here. |
Owner
|
@hopkink1 @bliessens thank you for your contributions! I'm not using it anymore, because I've switched from Java to TypeScript and therefore I can't test it or support you. Would you like to move it to a new org? I've noticed that there is an official integration: https://github.com/mybatis/spring-boot-starter It should be better than my integration. What do you think? |
Author
|
I believe mybatis/spring-boot-starter helps with using mybatis in the application, but doesn't specifically deal with mybatis-migrations, which is where your project fit in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Mybatis-Migration support to 3.3.7 to work around an error introduced by mybatis/migrations@a5d8a72#diff-2c0b0afa4090a13167224923f2536046. Also by checking if the script file exists before creating a MigrationReader, code now handles case when onabort.sql isn't found.