Skip to content

Conversation

@sprkrd
Copy link

@sprkrd sprkrd commented Nov 6, 2025

Addresses issues #16 and #58.

@netlify
Copy link

netlify bot commented Nov 6, 2025

👷 Deploy request for adoring-euclid-69d857 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 89f05b5

@facontidavide
Copy link
Contributor

facontidavide commented Nov 6, 2025

This logic in your PR seems wrong to me, because if door is open, the sequence fails (it should not fail)

@sprkrd
Copy link
Author

sprkrd commented Nov 6, 2025

This logic in your PR seems wrong to me, because if door is open, the sequence fails (it should not fail)

@facontidavide Of course, it's wrong. But I believe that is exactly the point of the "Find the bug!" text box later. The correct tree would look either like that of Commit 3b8a37c or like this:

DecoratorEnterRoom

But...

  1. At this point, the Fallback node hasn't been introduced yet (thus ruling out the image from Commit 3b8a37c)
  2. The section is meant to show an example of a decorator (thus partially ruling out the tree that I propose in the above image, there's actually another decorator that serves as an example).
  3. Like I said earlier, the "Find the bug!" text box later acknowledges the very mistake you've mentioned. In my PR I've expanded a bit on the original explanation. This rules out any correct version of the tree, and the only tree that is left as a valid candidate is the one from before Commit 3b8a37c with a Sequence instead of a Fallback.

@sprkrd
Copy link
Author

sprkrd commented Nov 6, 2025

Alternatively, the image after Commit 3b8a37c can be maintained but:

  1. The fallback node should be introduced before the decorator node.
  2. The "Find the BUG!" text box should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants