Building with a recent compiler fails due incompatible expected library #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
any news on this? |
Collaborator
|
thanks! |
Aglargil
pushed a commit
to Aglargil/BehaviorTree.CPP
that referenced
this pull request
Sep 6, 2024
…ry (BehaviorTree#833) * >Fixes build with newer clang/gcc * >Fixes build with newer clang/gcc * conditional build of sample nodes * using current head version for testing * moved to v0.8.0
Contributor
|
FYI #926 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build with a recent compiler (gcc 14.1/clang 17.0.1) the build failed due to the dependency expected-lite doesn't provide a make_unexpected when std::expected is included.
I've contacted the author and proposed a fix. He fixed the library and released v0.8.0.
I've taken the freedom to add the new expected-header to the source tree and also adapted a possible oversight (which also doesn't compile with a newer compiler. If the use of ´using ExpectedEntry = nonstd::expected_lite::expected<Entry, std::string>;´ is intended this needs to be fixed to be compatible within the expected-library, i guess.
Additionally I've added some changes to the CMakeLists file to disable building of the sample nodes if no test, nor examples are needed.
A general question: Currently the dependencies are hard-wired, any opinion towards using CPM or plain cmake FetchContent here?