Skip to content

fix: use dynamically growing error buffer in ParseScript #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2025
Merged

fix: use dynamically growing error buffer in ParseScript #1007

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15b782d
fix: use dynamically growing error buffer in ParseScript
GodGun123 Sep 10, 2025
8890b7f
style: format code
GodGun123 Sep 10, 2025
4df833b
fix: use dynamically growing error buffer in ValidateScript
GodGun123 Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/script_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,12 @@ using ErrorReport = lexy_ext::_report_error<char*>;

Expected<ScriptFunction> ParseScript(const std::string& script)
{
char error_msgs_buffer[2048];
std::string error_msgs_buffer; // dynamically growing error buffer

auto input = lexy::string_input<lexy::utf8_encoding>(script);
auto result =
lexy::parse<BT::Grammar::stmt>(input, ErrorReport().to(error_msgs_buffer));

auto reporter = ErrorReport().to(std::back_inserter(error_msgs_buffer));
auto result = lexy::parse<BT::Grammar::stmt>(input, reporter);
if(result.has_value() && result.error_count() == 0)
{
try
Expand Down Expand Up @@ -69,11 +70,12 @@ BT::Expected<Any> ParseScriptAndExecute(Ast::Environment& env, const std::string

Result ValidateScript(const std::string& script)
{
char error_msgs_buffer[2048];
std::string error_msgs_buffer; // dynamically growing error buffer

auto input = lexy::string_input<lexy::utf8_encoding>(script);
auto result =
lexy::parse<BT::Grammar::stmt>(input, ErrorReport().to(error_msgs_buffer));

auto reporter = ErrorReport().to(std::back_inserter(error_msgs_buffer));
auto result = lexy::parse<BT::Grammar::stmt>(input, reporter);
if(result.has_value() && result.error_count() == 0)
{
try
Expand Down
Loading