Merge pull request #1027 from BehaviorTree/fix_private_deps

Fix private deps

Author: facontidavide

3rdparty/lexy/CMakeLists.txt

@@ -9,7 +9,7 @@ option(LEXY_FORCE_CPP17     "Whether or not lexy should use C++17 even if compil
 
 add_subdirectory(src)
 
-option(LEXY_ENABLE_INSTALL   "whether or not to enable the install rule" ON)
+option(LEXY_ENABLE_INSTALL   "whether or not to enable the install rule" OFF)
 if(LEXY_ENABLE_INSTALL)
     include(CMakePackageConfigHelpers)
     include(GNUInstallDirs)

CMakeLists.txt

@@ -226,17 +226,29 @@ target_link_libraries(${BTCPP_LIBRARY}
     PRIVATE
         Threads::Threads
         ${CMAKE_DL_LIBS}
-        foonathan::lexy
-        minitrace::minitrace
-        tinyxml2::tinyxml2
-        minicoro::minicoro
-        flatbuffers::flatbuffers
-        $<$<BOOL:${BTCPP_GROOT_INTERFACE}>:cppzmq>
-        $<$<BOOL:${BTCPP_SQLITE_LOGGING}>:SQLite::SQLite3>
+        $<BUILD_INTERFACE:foonathan::lexy>
+        $<BUILD_INTERFACE:minitrace::minitrace>
+        $<BUILD_INTERFACE:tinyxml2::tinyxml2>
+        $<BUILD_INTERFACE:minicoro::minicoro>
+        $<BUILD_INTERFACE:flatbuffers::flatbuffers>
     PUBLIC
         ${BTCPP_EXTRA_LIBRARIES}
 )
 
+if(BTCPP_GROOT_INTERFACE)
+    target_link_libraries(${BTCPP_LIBRARY}
+        PRIVATE
+            $<BUILD_INTERFACE:cppzmq>
+    )
+endif()
+
+if(BTCPP_SQLITE_LOGGING)
+    target_link_libraries(${BTCPP_LIBRARY}
+        PRIVATE
+            $<BUILD_INTERFACE:SQLite::SQLite3>
+    )
+endif()
+
 target_include_directories(${BTCPP_LIBRARY}
     PUBLIC
         $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>

src/xml_parsing.cpp

@@ -29,11 +29,17 @@
 #if defined(__linux) || defined(__linux__)
 #pragma GCC diagnostic push
 #pragma GCC diagnostic ignored "-Wattributes"
+#pragma GCC diagnostic ignored "-Wtype-limits"
+#endif
+
+#include "tinyxml2.h"
+
+#if defined(__linux) || defined(__linux__)
+#pragma GCC diagnostic pop
 #endif
 
 #include <map>
 #include "behaviortree_cpp/xml_parsing.h"
-#include "tinyxml2.h"
 #include <filesystem>
 
 #ifdef USING_ROS2