add reset by default in base classes (fix #694)

Author: facontidavide

include/behaviortree_cpp/action_node.h

@@ -60,7 +60,9 @@ class SyncActionNode : public ActionNodeBase
 
   /// You don't need to override this
   virtual void halt() override final
-  {}
+  {
+    resetStatus();
+  }
 };
 
 /**

include/behaviortree_cpp/condition_node.h

@@ -27,7 +27,9 @@ class ConditionNode : public LeafNode
 
   //Do nothing
   virtual void halt() override final
-  {}
+  {
+    resetStatus();
+  }
 
   virtual NodeType type() const override final
   {

src/action_node.cpp

@@ -129,6 +129,7 @@ void CoroActionNode::tickImpl()
 void CoroActionNode::halt()
 {
   destroyCoroutine();
+  resetStatus(); // might be redundant
 }
 
 void CoroActionNode::destroyCoroutine()
@@ -183,6 +184,7 @@ void StatefulActionNode::halt()
   {
     onHalted();
   }
+  resetStatus(); // might be redundant
 }
 
 NodeStatus BT::ThreadedAction::executeTick()
@@ -238,4 +240,5 @@ void ThreadedAction::halt()
     thread_handle_.wait();
   }
   thread_handle_ = {};
+  resetStatus(); // might be redundant
 }

src/control_node.cpp

@@ -32,6 +32,7 @@ size_t ControlNode::childrenCount() const
 void ControlNode::halt()
 {
   resetChildren();
+  resetStatus(); // might be redundant
 }
 
 void ControlNode::resetChildren()

src/decorator_node.cpp

@@ -32,6 +32,7 @@ void DecoratorNode::setChild(TreeNode* child)
 void DecoratorNode::halt()
 {
   resetChild();
+  resetStatus(); // might be redundant
 }
 
 const TreeNode* DecoratorNode::child() const