fix issue with move semantic

Author: facontidavide

include/behaviortree_cpp/bt_factory.h

@@ -204,8 +204,8 @@ class BehaviorTreeFactory
   BehaviorTreeFactory(const BehaviorTreeFactory& other) = delete;
   BehaviorTreeFactory& operator=(const BehaviorTreeFactory& other) = delete;
 
-  BehaviorTreeFactory(BehaviorTreeFactory&& other) = default;
-  BehaviorTreeFactory& operator=(BehaviorTreeFactory&& other)  = default;
+  BehaviorTreeFactory(BehaviorTreeFactory&& other) noexcept;
+  BehaviorTreeFactory& operator=(BehaviorTreeFactory&& other) noexcept;
 
   /// Remove a registered ID.
   bool unregisterBuilder(const std::string& ID);

include/behaviortree_cpp/tree_node.h

@@ -137,8 +137,8 @@ class TreeNode
   TreeNode(const TreeNode& other) = delete;
   TreeNode& operator=(const TreeNode& other) = delete;
 
-  TreeNode(TreeNode&& other) = default;
-  TreeNode& operator=(TreeNode&& other) = default;
+  TreeNode(TreeNode&& other) noexcept;
+  TreeNode& operator=(TreeNode&& other) noexcept;
 
   virtual ~TreeNode();
 

include/behaviortree_cpp/xml_parsing.h

@@ -23,8 +23,8 @@ class XMLParser : public Parser
   XMLParser(const XMLParser& other) = delete;
   XMLParser& operator=(const XMLParser& other) = delete;
 
-  XMLParser(XMLParser&& other) = default;
-  XMLParser& operator=(XMLParser&& other) = default;
+  XMLParser(XMLParser&& other) noexcept;
+  XMLParser& operator=(XMLParser&& other) noexcept;
 
   void loadFromFile(const std::filesystem::path &filename, bool add_includes = true) override;
 

src/bt_factory.cpp

@@ -102,6 +102,17 @@ BehaviorTreeFactory::BehaviorTreeFactory():
   _p->scripting_enums = std::make_shared<std::unordered_map<std::string, int>>();
 }
 
+BehaviorTreeFactory::BehaviorTreeFactory(BehaviorTreeFactory &&other) noexcept
+{
+  this->_p = std::move(other._p);
+}
+
+BehaviorTreeFactory &BehaviorTreeFactory::operator=(BehaviorTreeFactory &&other) noexcept
+{
+  this->_p = std::move(other._p);
+  return *this;
+}
+
 BehaviorTreeFactory::~BehaviorTreeFactory()
 {}
 

src/tree_node.cpp

@@ -56,6 +56,17 @@ TreeNode::TreeNode(std::string name, NodeConfig config) :
 {
 }
 
+TreeNode::TreeNode(TreeNode &&other) noexcept
+{
+  this->_p = std::move(other._p);
+}
+
+TreeNode &TreeNode::operator=(TreeNode &&other) noexcept
+{
+  this->_p = std::move(other._p);
+  return *this;
+}
+
 TreeNode::~TreeNode() {}
 
 NodeStatus TreeNode::executeTick()

src/xml_parsing.cpp

@@ -96,6 +96,17 @@ struct XMLParser::PImpl
 XMLParser::XMLParser(const BehaviorTreeFactory& factory) : _p(new PImpl(factory))
 {}
 
+XMLParser::XMLParser(XMLParser &&other) noexcept
+{
+  this->_p = std::move(other._p);
+}
+
+XMLParser &XMLParser::operator=(XMLParser &&other) noexcept
+{
+  this->_p = std::move(other._p);
+  return *this;
+}
+
 XMLParser::~XMLParser()
 {}