Skip to content

Commit 43dd146

Browse files
committed
Fix default escpae for the attribut and content to the link
1 parent b19f317 commit 43dd146

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

inc/Helpers/Formatting/Link.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,15 +164,15 @@ function get_the_link( array $attributes, array $settings = [] ): string {
164164
$attributes_escaped[] = $name;
165165
} else {
166166
// Use user escape function, or default
167-
$value = escape_attribute_value( $value, $settings['escape'][ $name ] ?? '' );
167+
$value = escape_attribute_value( $value, $settings['escape'][ $name ] ?? 'esc_attr' );
168168
$attributes_escaped[] = sprintf( '%s="%s"', $name, $value );
169169
}
170170
}
171171

172172
// Implode all attributes for display purposes
173173
$attributes_escaped = implode( ' ', $attributes_escaped );
174174
// Escape content for display purposes
175-
$label = $settings['content'] ? escape_content_value( $settings['content'], $settings['escape']['content'] ?? '' ) : '';
175+
$label = $settings['content'] ? escape_content_value( $settings['content'], $settings['escape']['content'] ?? 'esc_html' ) : '';
176176

177177
$link_markup = sprintf( '<a %s>%s%s</a>', $attributes_escaped, $settings['new_window'], $label );
178178

0 commit comments

Comments
 (0)