[LocationPermission] Fix warning UI unresponsive in mainthread when c… (#1329)

kand-uit · web-flow · commit daf38b137bc9 · 2024-06-04T10:59:18.000+02:00
* [LocationPermission] Fix warning UI unresponsive in mainthread when calling locationServicesEnabled * fix issue #1002: bump version, fix Xcode location check warning * fix issue #1002: Xcode warning of the unresponsive of main thread when checking location state * bump version to 11.3.2 * bump version to 11.3.2: update changelog and fix #1002 * update permission_handler_apple dependency to minimum 9.4.5 * revert permission_handler_apple dependency * revert CHANGELOG.md * revert pubspec.yaml
diff --git a/permission_handler_apple/CHANGELOG.md b/permission_handler_apple/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 9.4.5
+
+* Fixes issue #1002, Xcode warning of the unresponsive of main thread when checking isLocationEnabled.
+  
 ## 9.4.4
 
 * Fixes potentially-nil return type of EventPermissionStrategy#getEntityType.
diff --git a/permission_handler_apple/ios/Classes/strategies/LocationPermissionStrategy.m b/permission_handler_apple/ios/Classes/strategies/LocationPermissionStrategy.m
@@ -36,7 +36,13 @@ - (PermissionStatus)checkPermissionStatus:(PermissionGroup)permission {
 }
 
 - (void)checkServiceStatus:(PermissionGroup)permission completionHandler:(ServiceStatusHandler)completionHandler {
-    completionHandler([CLLocationManager locationServicesEnabled] ? ServiceStatusEnabled : ServiceStatusDisabled);
+    dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{
+        BOOL isEnabled = [CLLocationManager locationServicesEnabled];
+
+        dispatch_async(dispatch_get_main_queue(), ^(void) {
+            completionHandler(isEnabled ? ServiceStatusEnabled : ServiceStatusDisabled);
+        });
+    });
 }
 
 - (void)requestPermission:(PermissionGroup)permission completionHandler:(PermissionStatusHandler)completionHandler errorHandler:(PermissionErrorHandler)errorHandler {
diff --git a/permission_handler_apple/pubspec.yaml b/permission_handler_apple/pubspec.yaml
@@ -2,7 +2,7 @@ name: permission_handler_apple
 description: Permission plugin for Flutter. This plugin provides the iOS API to request and check permissions.
 repository: https://github.com/baseflow/flutter-permission-handler
 issue_tracker: https://github.com/Baseflow/flutter-permission-handler/issues
-version: 9.4.4
+version: 9.4.5
 
 environment:
   sdk: ">=2.15.0 <4.0.0"

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,13 @@ - (PermissionStatus)checkPermissionStatus:(PermissionGroup)permission {`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`- (void)checkServiceStatus:(PermissionGroup)permission completionHandler:(ServiceStatusHandler)completionHandler {`
`39`		`- completionHandler([CLLocationManager locationServicesEnabled] ? ServiceStatusEnabled : ServiceStatusDisabled);`
	`39`	`+ dispatch_async(dispatch_get_global_queue( DISPATCH_QUEUE_PRIORITY_DEFAULT, 0), ^{`
	`40`	`+ BOOL isEnabled = [CLLocationManager locationServicesEnabled];`
	`41`	`+`
	`42`	`+ dispatch_async(dispatch_get_main_queue(), ^(void) {`
	`43`	`+ completionHandler(isEnabled ? ServiceStatusEnabled : ServiceStatusDisabled);`
	`44`	`+ });`
	`45`	`+ });`
`40`	`46`	`}`
`41`	`47`
`42`	`48`	`- (void)requestPermission:(PermissionGroup)permission completionHandler:(PermissionStatusHandler)completionHandler errorHandler:(PermissionErrorHandler)errorHandler {`